feat(run): Add smart short ID resolution for templates and playlist items#48
Open
feat(run): Add smart short ID resolution for templates and playlist items#48
Conversation
…tems - Add ResolvedTarget enum and resolve_target() function in storage.rs - Update 'runbox run' to accept optional [TARGET] positional argument - Smart resolution order: template exact match -> template prefix -> playlist item short ID - Show resolution info before execution (what matched, template, command) - Clear ambiguity error messages with all candidates listed - Add tests for resolve_target functionality Closes: ISSUE-033
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
runbox run <short_id>that can resolve any executable reference (template or playlist item) by short IDChanges Made
Storage Layer (
runbox-core/src/storage.rs)ResolvedTargetenum withTemplateandPlaylistItemvariantsResolveTargetErrorenum for resolution failures (NotFound, Ambiguous, Storage)Storage::resolve_target()method implementing smart resolution:CLI (
runbox-cli/src/main.rs)runbox runcommand to accept optional[TARGET]positional argumentcmd_run_smart()function that:Examples
Acceptance Criteria
runbox run <short_id>resolves templates by prefixrunbox run <short_id>resolves playlist items by hex short ID--templateflag still works as explicit override-- <command>direct execution still worksTesting
Closes: ISSUE-033