daemon: sanitize invalid UTF-8 in proto responses#418
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sanitizeUTF8/sanitizeUTF8Slicehelpers usingstrings.ToValidUTF8.Acceptance Criteria Evidence
1)
orch psworks even when issues contain invalid UTF-8Repro run against a live daemon with an issue file containing invalid bytes (
0xFF) in title/body:2)
orch monitordisplays runs correctlyMonitor consumes daemon
ListRuns/ListIssuesproto APIs. Verified those APIs over real socket framing with invalid UTF-8 payloads:This is the exact daemon boundary that previously failed marshal and caused client EOF.
3) Unit test for
sanitizeUTF8Validation
go build ./...go test ./internal/daemon -count=1go test ./test/integration -run TestPs -count=1make lintgo test ./...currently reports a pre-existing failure ininternal/cli(TestApplyConfigDefaultsFallbacks, config schema EOF), unrelated to this daemon change.Refs: orch-438