Fix codex orch send submission by using C-m#416
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
orch sendfor codex tmux runs by using agent-specific submit key handling.C-m(carriage return) for codex; keepEnterfor all other agents.Changes
internal/daemon/socket.goprocessSendTmuxnow always callsSendKeysLiteralfirst.tmuxSubmitKeyForAgent(agentName).C-m; others =>Enter.internal/daemon/socket_test.goTestTmuxSubmitKeyForAgentwith codex/case-insensitive/non-codex cases.Acceptance Criteria Evidence
1)
orch sendfor codex submits the messageExecuted from this branch binary with isolated daemon runtime + tmux wrapper:
Wrapper-captured tmux args from daemon:
Pane capture shows the marker was actually submitted and answered:
2) Verified codex submit key sequence
Live codex pane test on tmux session:
After
Enter:(message remains in input)
After
C-m:(submitted and processed)
3) Non-codex tmux agents unchanged
Enterfor non-codex:go test ./internal/daemon -run TestTmuxSubmitKeyForAgentgo test ./internal/multiplexer -run TestTmuxMultiplexer_SendKeys4) Added test
TestTmuxSubmitKeyForAgentininternal/daemon/socket_test.go.Validation Run
go build ./...✅go test ./...❌ (pre-existing unrelated failure)internal/cli/run_test.go:344 TestApplyConfigDefaultsFallbacksinvalid config schema ... EOFmake lint✅Refs: orch-436