feat(orch-monitor-tui): implement active daemon health checks with typed failures#406
Open
feat(orch-monitor-tui): implement active daemon health checks with typed failures#406
Conversation
…ped failures Replace passive socket-file-exists check with active ping probe for availability detection. Preserve typed failure causes (socket missing, connection refused, timeout, permission denied) throughout the stack. Closes #426
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Acceptance Criteria
test_stale_socket_returns_connection_refused_error,test_is_available_false_for_stale_sockettest_connection_refused_message_distinct,test_timeout_message_distincttest_client_can_reconnect_after_failure,test_persistent_connection_reconnects_on_failuretest_daemon_health.pyChanges
New Exception Types (
types.py)ProtoDaemonSocketMissingError- socket file doesn't existProtoDaemonConnectionRefusedError- stale socket or daemon not listeningProtoDaemonTimeoutError- daemon not respondingProtoDaemonPermissionError- permission deniedProto Client (
proto_client.hy)is-availablenow performs active ping probe (not just socket stat)socket-existsmethod for passive socket file checkcheck-healthmethod returning Result with specific error typesMacros (
macros.hy)socket-sendmacro catches and raises specific typed exceptionsAPI Layer (
daemon_api.py,orch_api.py)check_healthmethod onDaemonOrchAPITest Results
Closes orch-426