refactor(tui): move client-side filtering to daemon API (orch-395)#392
Open
refactor(tui): move client-side filtering to daemon API (orch-395)#392
Conversation
Remove FilterRows function from run_filter.go and pass all filter parameters (branch_state, pr_filter, issue_status, updated_within) to the daemon API. Closes orch-395
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ListRunsRequestproto with new filter fields:branch_state,pr_filter,issue_status,updated_within_secondsPRFilterenum to proto for PR filtering (ALL,HAS,NONE)proto_handler.gobuildListRunsFilter()FilterRowsfunction fromrun_filter.go(previously lines 319-383)Changes
api/orch.proto: Added filter fields and PRFilter enuminternal/daemon/proto_handler.go: AddedapplyExtendedRunFilters()for server-side filteringinternal/daemon/proto_client.go: AddedListRunsWithFilter()methodinternal/orchapi/types.go: ExtendedListRunsFilterstructinternal/orchapi/daemon_client.go: Updated to use new filter methodinternal/monitor/monitor.go: UpdatedloadRuns()andRefresh()to use server-side filteringinternal/monitor/run_filter.go: RemovedFilterRowsfunctioninternal/monitor/run_filter_test.go: Removed tests forFilterRowsVerification
go build ./...go test ./internal/monitor/...FilterRowsfunction removed fromrun_filter.goCloses orch-395