Skip to content

refactor(tui): move client-side filtering to daemon API (orch-395)#392

Open
proboscis wants to merge 1 commit intomainfrom
issue/orch-395/run-20260201-104420
Open

refactor(tui): move client-side filtering to daemon API (orch-395)#392
proboscis wants to merge 1 commit intomainfrom
issue/orch-395/run-20260201-104420

Conversation

@proboscis
Copy link
Owner

Summary

  • Extended ListRunsRequest proto with new filter fields: branch_state, pr_filter, issue_status, updated_within_seconds
  • Added PRFilter enum to proto for PR filtering (ALL, HAS, NONE)
  • Implemented server-side filtering in daemon's proto_handler.go
  • Updated TUI to pass all filter parameters to daemon API via buildListRunsFilter()
  • Removed FilterRows function from run_filter.go (previously lines 319-383)

Changes

  • api/orch.proto: Added filter fields and PRFilter enum
  • internal/daemon/proto_handler.go: Added applyExtendedRunFilters() for server-side filtering
  • internal/daemon/proto_client.go: Added ListRunsWithFilter() method
  • internal/orchapi/types.go: Extended ListRunsFilter struct
  • internal/orchapi/daemon_client.go: Updated to use new filter method
  • internal/monitor/monitor.go: Updated loadRuns() and Refresh() to use server-side filtering
  • internal/monitor/run_filter.go: Removed FilterRows function
  • internal/monitor/run_filter_test.go: Removed tests for FilterRows

Verification

  • All packages build: go build ./...
  • Monitor tests pass: go test ./internal/monitor/...
  • FilterRows function removed from run_filter.go
  • TUI passes filters to daemon API instead of filtering client-side

Closes orch-395

Remove FilterRows function from run_filter.go and pass all filter
parameters (branch_state, pr_filter, issue_status, updated_within)
to the daemon API.

Closes orch-395
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant