refactor(tui): remove client-side issue filtering from issues_dashboard.go#388
Open
refactor(tui): remove client-side issue filtering from issues_dashboard.go#388
Conversation
- Pass issue status filter to daemon ListIssues API instead of filtering client-side - Remove applyFilter() function from issues_dashboard.go - Move filterBranchesForIssue() from issues_dashboard.go to monitor.go - When filter toggles, trigger daemon refresh instead of local filtering - Update hasActiveFilters() UI to show (filtered) indicator without ratio This reduces client-side logic and centralizes filtering in the daemon. Resolves: orch-396
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ListIssuesAPI instead of filtering client-sideapplyFilter()function fromissues_dashboard.gofilterBranchesForIssue()fromissues_dashboard.gotomonitor.goChanges
Monitor.RefreshIssues()now builds a status filter based onshowResolvedandshowClosedsettings and passes it to the daemon APIapplyFilter()- the client-side filtering function that was duplicating daemon logicfilterBranchesForIssue()tomonitor.gowhere it's called from - this is not a TUI concern but a Monitor (daemon-adjacent) concernVerification
go build ./...passesgo test ./internal/monitor/...passes (all 54 tests)go test ./internal/daemon/... -run TestListIssuespassesRelated
Resolves: orch-396
Depends on: orch-383 (daemon issue status filter support - already merged)