feat(daemon): add filtering parameters to ListRuns API#386
Open
feat(daemon): add filtering parameters to ListRuns API#386
Conversation
0636081 to
f6e5493
Compare
Add server-side filtering to daemon's ListRuns API to replace client-side filtering and establish daemon as single source of truth. New parameters: - issue_status: filter by associated issue status (open/resolved/closed) - older_than: filter by age using human-readable format (7d, 2w, 1m) - agents: multi-value agent filter (replaces single agent parameter) - tags/tags_mode: filter by issue tags with AND/OR logic Closes orch-383
f6e5493 to
a4a9710
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds server-side filtering parameters to the daemon's
ListRunsAPI, enabling the daemon to handle all filtering logic instead of CLI/TUI performing client-side filtering.Changes
New API Parameters (
ListRunsRequest)issue_statusrepeated IssueStatusolder_thanstringagentsrepeated stringagentif set)tagsrepeated stringtags_modestringFiles Modified
api/orch.proto- Added new fields toListRunsRequestapi/orchpb/orch.pb.go- Regenerated protobuf codeinternal/store/store.go- ExtendedListRunsFilterstructinternal/daemon/proto_handler.go- Map proto fields to store filterinternal/daemon/proto_client.go- AddedListRunsWithOptionsmethodinternal/store/file/run_index.go- Implemented filtering logicinternal/orchapi/types.go- Extended client-side filter typesinternal/orchapi/daemon_client.go- Pass new fields to proto clientTesting
Evidence
Build and unit tests pass. The existing integration test failures are pre-existing issues unrelated to this change (they involve agent session handling and path resolution).
Closes orch-383