Skip to content

Conversation

@samcm
Copy link
Contributor

@samcm samcm commented Jul 25, 2024

No description provided.

@samcm
Copy link
Contributor Author

samcm commented Jul 25, 2024

Actually I'll close this and reopen it when the devnets/spec is a little more stable 😅

@samcm samcm closed this Jul 25, 2024
@barnabasbusa
Copy link

Pls reopen

@cortze cortze reopened this Aug 29, 2024
@codecov-commenter
Copy link

codecov-commenter commented Aug 29, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0.66445% with 299 lines in your changes missing coverage. Please review.

Project coverage is 2.88%. Comparing base (b94d32c) to head (113a74f).
Report is 143 commits behind head on main.

Files with missing lines Patch % Lines
eth/fetch.go 0.00% 87 Missing ⚠️
eth/network_config.go 0.00% 76 Missing ⚠️
eth/topic_score_params.go 0.00% 46 Missing ⚠️
eth/pubsub.go 0.00% 34 Missing ⚠️
cmd/hermes/cmd_eth.go 0.00% 32 Missing ⚠️
eth/node_config.go 0.00% 13 Missing ⚠️
cmd/hermes/cmd_eth_chains.go 0.00% 9 Missing ⚠️
eth/prysm.go 50.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff            @@
##            main     #35      +/-   ##
========================================
- Coverage   7.75%   2.88%   -4.87%     
========================================
  Files          7      30      +23     
  Lines        400    4122    +3722     
========================================
+ Hits          31     119      +88     
- Misses       361    3992    +3631     
- Partials       8      11       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cortze
Copy link
Contributor

cortze commented Sep 2, 2024

@samcm is this ready for review?

@samcm
Copy link
Contributor Author

samcm commented Sep 2, 2024

Sorry for the run-around @cortze - it's not at the moment. It's probably not far from the mark but IMO we're still too early on peerdas for this to hit any main branches. Feel free to close again, or leave open until we're closer to a finalized spec.

@barnabasbusa has been sentenced to 15 years of relentless YAML engineering in the DevOps dungeon with no LLM privileges. With good behaviour he'll have the opportunity to rejoin us here in the application layer after 10 years 😆

@cortze
Copy link
Contributor

cortze commented Sep 2, 2024

No worries at all @samcm , just give me a ping whenever this is ready for testing or for a review, or whenever @barnabasbusa gets granted his "conditional release" 🤣

@cortze cortze mentioned this pull request Oct 30, 2025
@cortze
Copy link
Contributor

cortze commented Oct 31, 2025

Closing this in favour of #79

@cortze cortze closed this Oct 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants