Action storage improvements #263
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This includes null for unlabelled choices/transitions (as for Model). This will allow aligning actions in a built model and its source, facilitating the use of action indices for efficiency. For now, this is optional: returning null indicates that the information is unavailable. ModulesFile supports this. BasicModelInfo is able to store/provide the info but, for now, explicit model import does not use this because it cannot provide the action list efficiently without searching all transitions.
To keep ModelGenerator and Model classes in synch, the existing get*ActionString methods in ModelGenerator, used only by the simulator, are renamed to get*ActionDescription. These provide source-dependent descriptions, e.g. module/[action] for PRISM models, rather than simply converting actions to strings.
In a similar style to the one in NondetModel.
Used e.g. when simulating explicitly imported models.
Was working before for PRISM models, because CTMCs are exposed as multiple action-labelled choices, but now works for other sources too, e.g., explicitly imported models.
(i.e. add null if an unlabelled self-loop was added to fix a deadlock) Not actually needed if the action set is later computed on demand, since the method to add a transition will take care of this, but this works more smoothly when the assumed action set is provided up front with ModelExplicit.setActions, as in e.g. ConstructModel.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ModelInfo supplies action list
Action lists used when building/transforming models
Additional action access methods (explicit engine)
Action to string access methods