feat: import updated <SliceSimulator> on new projects#1765
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves:
Description
This PR updates the Slice Simulator page templates generated during project initialization to import the
<SliceSimulator>component from its new location in the main SDK packages instead of the adapter's/simulatorsubpath.Changes by adapter:
Next.js (
adapter-next):@prismicio/nextinstead of@slicemachine/adapter-next/simulator@prismicio/next/pagesinstead of@slicemachine/adapter-next/simulatorNuxt (
adapter-nuxt):SliceSimulatorimport (now auto-imported by the Nuxt module)<script>before<template>(follows Vue style guide recommendation)SvelteKit (
adapter-sveltekit):SliceSimulatorandSliceZoneimports from@prismicio/svelteinstead of importingSliceSimulatorfrom@slicemachine/adapter-sveltekit/simulatorChecklist
Preview
N/A — This change affects generated code during project initialization, not visual components.
How to QA 1
SliceSimulatorfrom the correct package:@prismicio/next@prismicio/next/pages@prismicio/svelte🎉
Footnotes
Please use these labels when submitting a review:
⚠️ #issue: Strongly suggest a change.
❓ #ask: Ask a question.
💡 #idea: Suggest an idea.
🎉 #nice: Share a compliment. ↩