fix: mark text completed on every text-complete point of response parsing #874
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #870 (comment)
Description
Fixes a bug where OpenAI (and potentially other providers) would emit
TextCompleteEventwithout a correspondingTextStartEventafter the first text cycle when responses contained multiple output items.Root Cause
The
textStartedflag inStreamStatewas never reset once aTextCompleteEventwas emitted. When OpenAI responses contained multiple output items (content parts), the flag remainedtrueafter the first text block completed, causing subsequent text blocks to skip theirTextStartEventand proceed directly toTextDeltaEvent.Changes
markTextCompleted()method to reset thetextStartedflagmarkTextCompleted()call before everyTextCompleteEventemission across all providers (OpenAI, Anthropic, Gemini, DeepSeek, OpenRouter, XAI, Groq, Ollama, Mistral)markTextCompleted()properly resets the flagResult
Each text block in a streaming response now properly emits its own complete cycle:
TextStartEvent→TextDeltaEvent(s) →TextCompleteEvent, regardless of how many output items the provider returns.Breaking Changes
None. This is a bug fix that maintains full backward compatibility while ensuring correct event emission for multi-part text responses.