fix(openai): stream start order #873
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Preview deployments for prism ⚡️
Commit: Deployment ID: Static site name: |
Contributor
Author
|
Closing in favor of https://github.com/prism-php/prism/pull/874/files |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #870
Changes
markTextCompleted()method toStreamStatethat resets thetextStartedflagmarkTextCompleted()after emittingTextCompleteEventin the OpenAI stream handlerRoot Cause
When OpenAI returns multiple text content parts in a single response, the handler emitted
TextStartonly once (on first text delta) butTextCompletefor each part. After the firstTextComplete, subsequent text deltas arrived without triggering a newTextStartbecausetextStartedremainedtrue.