Improve diff output #41
Conversation
GeertJohan
force-pushed
the
improve-diff-output
branch
from
b86ab59 to
64eab20
Compare
internal/diff.go
Outdated
| fromDB := stdlib.OpenDB(*migrateConn.Config()) | ||
| fromDB.SetMaxOpenConns(diffMaxOpenConns) | ||
| defer fromDB.Close() | ||
| err := fromDB.Ping() | ||
| err := fromDB.PingContext(ctx) | ||
| if err != nil { | ||
| return "", fmt.Errorf("failed to open 'from database' connection: %w", err) | ||
| } | ||
|
|
||
| toDB := stdlib.OpenDB(*migrateConn.Config()) | ||
| toDB := stdlib.OpenDB(*targetConn.Config()) |
There was a problem hiding this comment.
Maybe name them fromConn and toConn to avoid mistakes in the future and also make it easier to understand?
There was a problem hiding this comment.
I originally named them like this to match their names elsewhere in trek (e.g. generate.go)
There was a problem hiding this comment.
But I guess from and to makes more sense from the perspective of the Diff function; it has no knowledge of the origin of target and migrate.
There was a problem hiding this comment.
But I guess from and to makes more sense from the perspective of the Diff function; it has no knowledge of the origin of target and migrate.
mise.toml
Outdated
| @@ -0,0 +1,2 @@ | |||
| [tools] | |||
| golangci-lint = "2.6.1" | |||
There was a problem hiding this comment.
CI uses 2.7.2 already (which currently is the latest release):
trek/.github/workflows/main.yaml
Line 22 in be4f3bf
GeertJohan
force-pushed
the
improve-diff-output
branch
from
64eab20 to
69254f5
Compare
Fixed #39