Skip to content

Fix issues with new chafa #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Frederick888 wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix issues with new chafa #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
92b284a
fix: add chafa arguments '--format symbols'
Frederick888 Mar 17, 2025
46a42fb
fix: use chafa arguments '--polite on' to suppress escape sequences
Frederick888 Mar 17, 2025
3c8f412
fix: migrate to new vim.health APIs
Frederick888 May 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions lua/chafa/health.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
local M = {}

M.check = function()
vim.health.report_start("chafa.nvim health check")
vim.health.start("chafa.nvim health check")
if vim.fn.executable("chafa") == 1 then
vim.health.report_ok("no issues found")
vim.health.ok("no issues found")
else
vim.health.report_error("chafa executable not found")
vim.health.report_info("Follow installations instructions at https://hpjansson.org/chafa/download/")
vim.health.error("chafa executable not found")
vim.health.info("Follow installations instructions at https://hpjansson.org/chafa/download/")
end
end

Expand Down
3 changes: 1 addition & 2 deletions lua/chafa/init.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,13 +11,12 @@ local global_opts = nil

---@diagnostic disable-next-line: unused-local
local get_image_data_sync = function(buf_path, width, height, opts, callback)
local command = { "chafa", buf_path, "--size", width .. "x" .. height }
local command = { "chafa", buf_path, "--size", width .. "x" .. height, "--format", "symbols", "--polite", "on" }

vim.fn.jobstart(command, {
stdout_buffered = true,
on_stdout = function(_, data)
if data then
table.remove(data)
callback(data)
end
end,
Expand Down