Skip to content

fix: use robust wait strategy for postgres testcontainers #888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kant777 merged 1 commit into from
Feb 10, 2026
Merged

fix: use robust wait strategy for postgres testcontainers #888

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion bridge/standard/pkg/store/store_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import (
"fmt"
"math/big"
"testing"
"time"

"github.com/ethereum/go-ethereum/common"
"github.com/primev/mev-commit/bridge/standard/pkg/store"
Expand Down Expand Up @@ -33,7 +34,12 @@ func TestStore(t *testing.T) {
"POSTGRES_USER": "user",
"POSTGRES_PASSWORD": "password",
},
WaitingFor: wait.ForListeningPort("5432/tcp"),
WaitingFor: wait.ForAll(
wait.ForLog("database system is ready to accept connections").
WithOccurrence(2).
WithStartupTimeout(60*time.Second),
wait.ForListeningPort("5432/tcp"),
),
}

// Start the PostgreSQL container
Expand Down
8 changes: 7 additions & 1 deletion oracle/pkg/store/store_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import (
"fmt"
"math/big"
"testing"
"time"

"github.com/ethereum/go-ethereum/common"
"github.com/google/go-cmp/cmp"
Expand Down Expand Up @@ -46,7 +47,12 @@ func TestStore(t *testing.T) {
"POSTGRES_USER": "user",
"POSTGRES_PASSWORD": "password",
},
WaitingFor: wait.ForListeningPort("5432/tcp"),
WaitingFor: wait.ForAll(
wait.ForLog("database system is ready to accept connections").
WithOccurrence(2).
WithStartupTimeout(60*time.Second),
wait.ForListeningPort("5432/tcp"),
),
}

// Start the PostgreSQL container
Expand Down
7 changes: 6 additions & 1 deletion tools/preconf-rpc/store/store_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,12 @@ func TestStore(t *testing.T) {
"POSTGRES_USER": "user",
"POSTGRES_PASSWORD": "password",
},
WaitingFor: wait.ForListeningPort("5432/tcp"),
WaitingFor: wait.ForAll(
wait.ForLog("database system is ready to accept connections").
WithOccurrence(2).
WithStartupTimeout(60*time.Second),
wait.ForListeningPort("5432/tcp"),
),
}

// Start the PostgreSQL container
Expand Down
Loading