(Optional) fix for .debug_line head generation #51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
gcc-mirror/gcc@14a774a |
This was referenced Jun 18, 2022
laqieer
added a commit
to laqieer/FE_GBA_Function_Library
that referenced
this pull request
Sep 5, 2022
Contributor
Author
|
Updated this to not enable new fixed behavior by default. |
luckytyphlosion
requested changes
Apr 5, 2023
gcc/toplev.c
Outdated
Comment on lines
588
to
589
| /* Use old (buggy) DWARF line info generator. */ | ||
| int flag_fixed_debug_line_info = 0; |
laqieer
added a commit
to laqieer/fireemblem8u
that referenced
this pull request
Apr 5, 2023
Add `-ffix-debug-line` option to fix bug of `.debug_line` section
This was referenced Apr 5, 2023
jiangzhengwenjz
added a commit
to jiangzhengwenjz/katam
that referenced
this pull request
Apr 5, 2023
jiangzhengwenjz
added a commit
to jiangzhengwenjz/csm3
that referenced
this pull request
Apr 5, 2023
jiangzhengwenjz
added a commit
to jiangzhengwenjz/totkol
that referenced
this pull request
Apr 5, 2023
jiangzhengwenjz
added a commit
to jiangzhengwenjz/auroraticket
that referenced
this pull request
Apr 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes when using tools for reading line number information out of objects generated by agbcc, you'd get the follwing error:
This is presumably caused by the function
size_of_line_info(in gcc/dwarf2out.c) sometimes mispredicting the actual size of the rest of the.debug_linesection. This was fixed here by generating label deltas instead of using that function (as is done in more recent versions of GCC).The optional
-ffix-debug-lineflag enables this new behavior.Note: that fix probably needs to eventually be ported to agbcc_arm as well as any fork featuring agbcp.
I'm only now seeing that there's another debug info related PR in (#49) featuring the addition of a new flag. Perhaps it would be interesting to merge the flags into an unified one that either updates/fixes debug info generation or restores the old buggy one.