Upgrade PyTorch Lightning from 1.9.5 to 2.5.1 #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR upgrades the project from PyTorch Lightning 1.9.5 to 2.5.1 by updating API usage and import paths.
- Updated import of CombinedLoader and removal of deprecated Lightning hooks
- Replaced training_epoch_end/validation_epoch_end with on_train_epoch_end/on_validation_epoch_end and added manual accumulation of step outputs
- Updated the trainer initialization to use the new ckpt_path parameter
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| cortex/model/tree/_seq_model_tree.py | Updated import and hook methods; added manual step output accumulation |
| cortex/cmdline/train_cortex_model.py | Updated checkpoint loading parameter to use ckpt_path |
Files not reviewed (1)
- requirements.in: Language not supported
kleinhenz
reviewed
Apr 3, 2025
This commit implements the following changes: - Update imports from pytorch_lightning to lightning.pytorch - Replace deprecated CombinedLoader import path - Change *_epoch_end hooks to on_*_epoch_end hooks - Add step output collection for epoch-end processing - Update trainer.fit() to use ckpt_path - Update requirements.in to use lightning>=2.5.1,<2.6 - Remove pytorch-lightning package dependency
samuelstanton
force-pushed
the
lightning-version-bump
branch
from
1e666d6 to
c201717
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades the project from PyTorch Lightning 1.9.5 to 2.5.1. It implements necessary API changes including
The requirements have been updated to specify lightning>=2.0