This repository was archived by the owner on Apr 20, 2023. It is now read-only.
Ensure numbers remain as numbers.#42
Open
crabmusket wants to merge 1 commit intoprajwalkman:masterfrom
crabmusket:ensure-number
Open
Ensure numbers remain as numbers.#42crabmusket wants to merge 1 commit intoprajwalkman:masterfrom crabmusket:ensure-number
crabmusket wants to merge 1 commit intoprajwalkman:masterfrom
crabmusket:ensure-number
Conversation
Previously, the call to toFixed would turn numbers into strings, which was playing havoc with models bound to <input type="number"> elements.
Author
|
Just realised this is an incorrect solution! I'll rebase the commit, but I'm actually stumped as to what solution you'd prefer. The problem is the |
Author
|
I've ended up rewriting the default translation function: This means that a provided |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the call to toFixed would turn numbers into strings, which was playing havoc with models bound to
<input type="number">elements.