Queue and Worker Registry #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyt2y3
commented
Jan 8, 2026
Comment on lines
+4
to
+5
| #[derive(oxanus::Registry)] | ||
| struct ComponentRegistry(oxanus::ComponentRegistry<WorkerContext, WorkerError>); |
Collaborator
Author
There was a problem hiding this comment.
ComponentRegistry is a unique type owned by user's crate.
Each ComponentRegistry is unique, and would only contain types that's registered to it statically.
The derive macros generate register_component!(ComponentRegistry, TestWorker) under the hood.
tyt2y3
commented
Jan 8, 2026
Comment on lines
-83
to
-90
| let config = oxanus::Config::new(&storage.clone()) | ||
| .register_queue::<QueueOne>() | ||
| .register_queue::<QueueTwo>() | ||
| .register_queue::<QueueThrottled>() | ||
| .register_worker::<Worker1Sec>() | ||
| .register_worker::<Worker2Sec>() | ||
| .register_worker::<WorkerInstant>() | ||
| .register_worker::<WorkerInstant2>() |
Collaborator
Author
There was a problem hiding this comment.
On runtime, build_config would iterate all queues and workers and build the config object.
Manual register is no longer needed.
tyt2y3
commented
Jan 8, 2026
Collaborator
Author
There was a problem hiding this comment.
this is the best minimal example
reneklacan
approved these changes
Jan 9, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ComponentRegistryhas to be in scope when Queue and Worker are derived, in which they will automatically be registered to it.Then on runtime we can use
ComponentRegistry::build_configto construct the config object.This removes the need to manually register and thus wouldn't "forget" about them.