Use MLK_MUST_CHECK_RETURN_VALUE for all functions with return values #1454
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
hanno-becker
commented
Jan 2, 2026
hanno-becker
commented
- Resolves Add MLK_MUST_CHECK_RETURN_VALUE to all internal functions that can fail #1399
mkannwischer
previously approved these changes
Jan 2, 2026
Contributor
mkannwischer
left a comment
mkannwischer
left a comment
There was a problem hiding this comment.
Thanks @hanno-becker. LGTM.
mkannwischer
force-pushed
the
can_fail_must_check
branch
from
0e9bed7 to
077a246
Compare
Signed-off-by: Hanno Becker <beckphan@amazon.co.uk>
Signed-off-by: Hanno Becker <beckphan@amazon.co.uk>
hanno-becker
force-pushed
the
can_fail_must_check
branch
from
077a246 to
09abc74
Compare
Contributor
Author
|
CBMC runtime for ML-KEM-1024, indcpa_keypair_derand, degrades to ~30min, blocking PR. |
hanno-becker
dismissed
mkannwischer’s stale review
CBMC performance degradation too large to consider merging. Dismissing review to prevent accidental merge.
Signed-off-by: Hanno Becker <beckphan@amazon.co.uk>
hanno-becker
force-pushed
the
can_fail_must_check
branch
from
4f68a42 to
5cbc846
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.