linting: add shellcheck support for shell script linting #1329
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
L-series
changed the title
L-series
force-pushed
the
shellcheck
branch
5 times, most recently
from
63f1559 to
5624f82
Compare
L-series
added
bug
L-series
force-pushed
the
shellcheck
branch
2 times, most recently
from
d02382d to
4c22fbd
Compare
hanno-becker
reviewed
Jan 5, 2026
hanno-becker
requested changes
Jan 5, 2026
Contributor
hanno-becker
left a comment
hanno-becker
left a comment
There was a problem hiding this comment.
Thank you for your patience, @L-series. I noticed one major inefficiency in lint which we might want to address along the way; see comment.
Add linting for shell scripts in the scipts directory as well as any *.sh file accross the project using shellcheck. Signed-off-by: Andreas Hatziiliou <andreas.hatziiliou@savoirfairelinux.com>
Contributor
Author
|
@hanno-becker No worries! I made the changes to |
Fix errors brought up by the linter. Signed-off-by: Andreas Hatziiliou <andreas.hatziiliou@savoirfairelinux.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr introduces linting for shell scripts. It also fixes the warnings that the linter brought up initally.
#1300