-
Notifications
You must be signed in to change notification settings - Fork 32
verify: Switch to constant-time memcmp #838
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
41dabe5 to
9d18dcd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mac Mini (M1, 2020) benchmarks (opt)
Details
| Benchmark suite | Current: 9d18dcd | Previous: 8016262 | Ratio |
|---|---|---|---|
ML-DSA-44 keypair |
46418 cycles |
46416 cycles |
1.00 |
ML-DSA-44 sign |
131273 cycles |
131295 cycles |
1.00 |
ML-DSA-44 verify |
47776 cycles |
47770 cycles |
1.00 |
ML-DSA-65 keypair |
81317 cycles |
81316 cycles |
1.00 |
ML-DSA-65 sign |
216958 cycles |
216950 cycles |
1.00 |
ML-DSA-65 verify |
80082 cycles |
80029 cycles |
1.00 |
ML-DSA-87 keypair |
132551 cycles |
132556 cycles |
1.00 |
ML-DSA-87 sign |
277609 cycles |
277692 cycles |
1.00 |
ML-DSA-87 verify |
130337 cycles |
130412 cycles |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Arm Cortex-A76 (Raspberry Pi 5) benchmarks (opt)
Details
| Benchmark suite | Current: 9d18dcd | Previous: 8016262 | Ratio |
|---|---|---|---|
ML-DSA-44 keypair |
114076 cycles |
114006 cycles |
1.00 |
ML-DSA-44 sign |
360281 cycles |
360104 cycles |
1.00 |
ML-DSA-44 verify |
117895 cycles |
118170 cycles |
1.00 |
ML-DSA-65 keypair |
197917 cycles |
197678 cycles |
1.00 |
ML-DSA-65 sign |
594214 cycles |
593878 cycles |
1.00 |
ML-DSA-65 verify |
194707 cycles |
194834 cycles |
1.00 |
ML-DSA-87 keypair |
323927 cycles |
324011 cycles |
1.00 |
ML-DSA-87 sign |
758917 cycles |
758768 cycles |
1.00 |
ML-DSA-87 verify |
320215 cycles |
320690 cycles |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mac Mini (M1, 2020) benchmarks (no-opt)
Details
| Benchmark suite | Current: 9d18dcd | Previous: 8016262 | Ratio |
|---|---|---|---|
ML-DSA-44 keypair |
114533 cycles |
114377 cycles |
1.00 |
ML-DSA-44 sign |
429487 cycles |
428657 cycles |
1.00 |
ML-DSA-44 verify |
122478 cycles |
122381 cycles |
1.00 |
ML-DSA-65 keypair |
195926 cycles |
196350 cycles |
1.00 |
ML-DSA-65 sign |
696915 cycles |
696948 cycles |
1.00 |
ML-DSA-65 verify |
197611 cycles |
197609 cycles |
1.00 |
ML-DSA-87 keypair |
322946 cycles |
322857 cycles |
1.00 |
ML-DSA-87 sign |
879282 cycles |
879054 cycles |
1.00 |
ML-DSA-87 verify |
328155 cycles |
328163 cycles |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Arm Cortex-A76 (Raspberry Pi 5) benchmarks (no-opt)
Details
| Benchmark suite | Current: 9d18dcd | Previous: 8016262 | Ratio |
|---|---|---|---|
ML-DSA-44 keypair |
213588 cycles |
213309 cycles |
1.00 |
ML-DSA-44 sign |
790283 cycles |
783866 cycles |
1.01 |
ML-DSA-44 verify |
228802 cycles |
229575 cycles |
1.00 |
ML-DSA-65 keypair |
381779 cycles |
381367 cycles |
1.00 |
ML-DSA-65 sign |
1273125 cycles |
1271834 cycles |
1.00 |
ML-DSA-65 verify |
371997 cycles |
371831 cycles |
1.00 |
ML-DSA-87 keypair |
606702 cycles |
605562 cycles |
1.00 |
ML-DSA-87 sign |
1614848 cycles |
1613754 cycles |
1.00 |
ML-DSA-87 verify |
616717 cycles |
617405 cycles |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
oqs-bot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Intel Xeon 4th gen (c7i)
Details
| Benchmark suite | Current: 9d18dcd | Previous: 8016262 | Ratio |
|---|---|---|---|
ML-DSA-44 keypair |
34851 cycles |
34645 cycles |
1.01 |
ML-DSA-44 sign |
120419 cycles |
119831 cycles |
1.00 |
ML-DSA-44 verify |
38162 cycles |
38217 cycles |
1.00 |
ML-DSA-65 keypair |
60812 cycles |
60933 cycles |
1.00 |
ML-DSA-65 sign |
198455 cycles |
199178 cycles |
1.00 |
ML-DSA-65 verify |
62328 cycles |
62625 cycles |
1.00 |
ML-DSA-87 keypair |
93328 cycles |
93207 cycles |
1.00 |
ML-DSA-87 sign |
229757 cycles |
228709 cycles |
1.00 |
ML-DSA-87 verify |
93654 cycles |
94715 cycles |
0.99 |
This comment was automatically generated by workflow using github-action-benchmark.
oqs-bot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Intel Xeon 4th gen (c7i) (no-opt)
Details
| Benchmark suite | Current: 9d18dcd | Previous: 8016262 | Ratio |
|---|---|---|---|
ML-DSA-44 keypair |
95715 cycles |
95537 cycles |
1.00 |
ML-DSA-44 sign |
343632 cycles |
344827 cycles |
1.00 |
ML-DSA-44 verify |
100220 cycles |
99517 cycles |
1.01 |
ML-DSA-65 keypair |
161704 cycles |
160942 cycles |
1.00 |
ML-DSA-65 sign |
548950 cycles |
548684 cycles |
1.00 |
ML-DSA-65 verify |
162625 cycles |
161630 cycles |
1.01 |
ML-DSA-87 keypair |
267558 cycles |
267009 cycles |
1.00 |
ML-DSA-87 sign |
713204 cycles |
712714 cycles |
1.00 |
ML-DSA-87 verify |
269098 cycles |
270195 cycles |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
oqs-bot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Intel Xeon 3rd gen (c6i)
Details
| Benchmark suite | Current: 9d18dcd | Previous: 8016262 | Ratio |
|---|---|---|---|
ML-DSA-44 keypair |
56772 cycles |
56530 cycles |
1.00 |
ML-DSA-44 sign |
179718 cycles |
179858 cycles |
1.00 |
ML-DSA-44 verify |
61191 cycles |
61291 cycles |
1.00 |
ML-DSA-65 keypair |
99135 cycles |
99025 cycles |
1.00 |
ML-DSA-65 sign |
295675 cycles |
295553 cycles |
1.00 |
ML-DSA-65 verify |
99961 cycles |
100219 cycles |
1.00 |
ML-DSA-87 keypair |
153112 cycles |
152618 cycles |
1.00 |
ML-DSA-87 sign |
351525 cycles |
351659 cycles |
1.00 |
ML-DSA-87 verify |
153497 cycles |
152702 cycles |
1.01 |
This comment was automatically generated by workflow using github-action-benchmark.
oqs-bot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AMD EPYC 3rd gen (c6a)
Details
| Benchmark suite | Current: 9d18dcd | Previous: 8016262 | Ratio |
|---|---|---|---|
ML-DSA-44 keypair |
69454 cycles |
69297 cycles |
1.00 |
ML-DSA-44 sign |
183958 cycles |
183910 cycles |
1.00 |
ML-DSA-44 verify |
69771 cycles |
69377 cycles |
1.01 |
ML-DSA-65 keypair |
119220 cycles |
119470 cycles |
1.00 |
ML-DSA-65 sign |
292688 cycles |
294481 cycles |
0.99 |
ML-DSA-65 verify |
115302 cycles |
115711 cycles |
1.00 |
ML-DSA-87 keypair |
204022 cycles |
203563 cycles |
1.00 |
ML-DSA-87 sign |
386885 cycles |
387292 cycles |
1.00 |
ML-DSA-87 verify |
195149 cycles |
195391 cycles |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
oqs-bot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Graviton4
Details
| Benchmark suite | Current: 9d18dcd | Previous: 8016262 | Ratio |
|---|---|---|---|
ML-DSA-44 keypair |
68402 cycles |
68550 cycles |
1.00 |
ML-DSA-44 sign |
202117 cycles |
202344 cycles |
1.00 |
ML-DSA-44 verify |
70824 cycles |
70828 cycles |
1.00 |
ML-DSA-65 keypair |
121746 cycles |
121521 cycles |
1.00 |
ML-DSA-65 sign |
330955 cycles |
331568 cycles |
1.00 |
ML-DSA-65 verify |
117859 cycles |
117947 cycles |
1.00 |
ML-DSA-87 keypair |
198764 cycles |
199409 cycles |
1.00 |
ML-DSA-87 sign |
427218 cycles |
428420 cycles |
1.00 |
ML-DSA-87 verify |
194431 cycles |
195225 cycles |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Arm Cortex-A55 (Snapdragon 888) benchmarks (opt)
Details
| Benchmark suite | Current: 9d18dcd | Previous: 8016262 | Ratio |
|---|---|---|---|
ML-DSA-44 keypair |
280076 cycles |
278596 cycles |
1.01 |
ML-DSA-44 sign |
845410 cycles |
837663 cycles |
1.01 |
ML-DSA-44 verify |
277364 cycles |
278908 cycles |
0.99 |
ML-DSA-65 keypair |
478696 cycles |
480905 cycles |
1.00 |
ML-DSA-65 sign |
1377624 cycles |
1364158 cycles |
1.01 |
ML-DSA-65 verify |
454941 cycles |
456183 cycles |
1.00 |
ML-DSA-87 keypair |
824004 cycles |
818738 cycles |
1.01 |
ML-DSA-87 sign |
1866999 cycles |
1899234 cycles |
0.98 |
ML-DSA-87 verify |
791714 cycles |
785082 cycles |
1.01 |
This comment was automatically generated by workflow using github-action-benchmark.
oqs-bot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Intel Xeon 3rd gen (c6i) (no-opt)
Details
| Benchmark suite | Current: 9d18dcd | Previous: 8016262 | Ratio |
|---|---|---|---|
ML-DSA-44 keypair |
158482 cycles |
158695 cycles |
1.00 |
ML-DSA-44 sign |
569248 cycles |
567171 cycles |
1.00 |
ML-DSA-44 verify |
169878 cycles |
169623 cycles |
1.00 |
ML-DSA-65 keypair |
268168 cycles |
268478 cycles |
1.00 |
ML-DSA-65 sign |
916541 cycles |
916110 cycles |
1.00 |
ML-DSA-65 verify |
273622 cycles |
273550 cycles |
1.00 |
ML-DSA-87 keypair |
449187 cycles |
449578 cycles |
1.00 |
ML-DSA-87 sign |
1169968 cycles |
1171243 cycles |
1.00 |
ML-DSA-87 verify |
458108 cycles |
458741 cycles |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
oqs-bot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AMD EPYC 3rd gen (c6a) (no-opt)
Details
| Benchmark suite | Current: 9d18dcd | Previous: 8016262 | Ratio |
|---|---|---|---|
ML-DSA-44 keypair |
134981 cycles |
134750 cycles |
1.00 |
ML-DSA-44 sign |
534769 cycles |
533335 cycles |
1.00 |
ML-DSA-44 verify |
147211 cycles |
146879 cycles |
1.00 |
ML-DSA-65 keypair |
226785 cycles |
227179 cycles |
1.00 |
ML-DSA-65 sign |
869574 cycles |
870096 cycles |
1.00 |
ML-DSA-65 verify |
234701 cycles |
234815 cycles |
1.00 |
ML-DSA-87 keypair |
371089 cycles |
371690 cycles |
1.00 |
ML-DSA-87 sign |
1089816 cycles |
1088771 cycles |
1.00 |
ML-DSA-87 verify |
382592 cycles |
383137 cycles |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
oqs-bot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AMD EPYC 4th gen (c7a)
Details
| Benchmark suite | Current: 9d18dcd | Previous: 8016262 | Ratio |
|---|---|---|---|
ML-DSA-44 keypair |
41375 cycles |
40372 cycles |
1.02 |
ML-DSA-44 sign |
129169 cycles |
128749 cycles |
1.00 |
ML-DSA-44 verify |
43332 cycles |
43488 cycles |
1.00 |
ML-DSA-65 keypair |
72424 cycles |
72770 cycles |
1.00 |
ML-DSA-65 sign |
211323 cycles |
210355 cycles |
1.00 |
ML-DSA-65 verify |
72595 cycles |
73324 cycles |
0.99 |
ML-DSA-87 keypair |
108903 cycles |
108539 cycles |
1.00 |
ML-DSA-87 sign |
247973 cycles |
248683 cycles |
1.00 |
ML-DSA-87 verify |
110851 cycles |
111365 cycles |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
oqs-bot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Graviton4 (no-opt)
Details
| Benchmark suite | Current: 9d18dcd | Previous: 8016262 | Ratio |
|---|---|---|---|
ML-DSA-44 keypair |
128718 cycles |
128810 cycles |
1.00 |
ML-DSA-44 sign |
456793 cycles |
456529 cycles |
1.00 |
ML-DSA-44 verify |
137026 cycles |
137322 cycles |
1.00 |
ML-DSA-65 keypair |
221284 cycles |
221879 cycles |
1.00 |
ML-DSA-65 sign |
737548 cycles |
738462 cycles |
1.00 |
ML-DSA-65 verify |
221152 cycles |
222397 cycles |
0.99 |
ML-DSA-87 keypair |
365363 cycles |
367234 cycles |
0.99 |
ML-DSA-87 sign |
939542 cycles |
941155 cycles |
1.00 |
ML-DSA-87 verify |
370416 cycles |
372114 cycles |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
oqs-bot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Graviton3
Details
| Benchmark suite | Current: 9d18dcd | Previous: 8016262 | Ratio |
|---|---|---|---|
ML-DSA-44 keypair |
72631 cycles |
72726 cycles |
1.00 |
ML-DSA-44 sign |
212445 cycles |
212178 cycles |
1.00 |
ML-DSA-44 verify |
75791 cycles |
75763 cycles |
1.00 |
ML-DSA-65 keypair |
128395 cycles |
128356 cycles |
1.00 |
ML-DSA-65 sign |
350365 cycles |
350332 cycles |
1.00 |
ML-DSA-65 verify |
125542 cycles |
125640 cycles |
1.00 |
ML-DSA-87 keypair |
206654 cycles |
209435 cycles |
0.99 |
ML-DSA-87 sign |
444535 cycles |
450222 cycles |
0.99 |
ML-DSA-87 verify |
204810 cycles |
205369 cycles |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
oqs-bot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AMD EPYC 4th gen (c7a) (no-opt)
Details
| Benchmark suite | Current: 9d18dcd | Previous: 8016262 | Ratio |
|---|---|---|---|
ML-DSA-44 keypair |
120424 cycles |
120310 cycles |
1.00 |
ML-DSA-44 sign |
452531 cycles |
453130 cycles |
1.00 |
ML-DSA-44 verify |
129658 cycles |
130081 cycles |
1.00 |
ML-DSA-65 keypair |
203977 cycles |
206452 cycles |
0.99 |
ML-DSA-65 sign |
738744 cycles |
744609 cycles |
0.99 |
ML-DSA-65 verify |
209847 cycles |
209667 cycles |
1.00 |
ML-DSA-87 keypair |
340228 cycles |
338390 cycles |
1.01 |
ML-DSA-87 sign |
941854 cycles |
933546 cycles |
1.01 |
ML-DSA-87 verify |
349359 cycles |
346236 cycles |
1.01 |
This comment was automatically generated by workflow using github-action-benchmark.
oqs-bot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Graviton2
Details
| Benchmark suite | Current: 9d18dcd | Previous: 8016262 | Ratio |
|---|---|---|---|
ML-DSA-44 keypair |
114302 cycles |
114342 cycles |
1.00 |
ML-DSA-44 sign |
360617 cycles |
360533 cycles |
1.00 |
ML-DSA-44 verify |
118211 cycles |
118221 cycles |
1.00 |
ML-DSA-65 keypair |
198192 cycles |
197609 cycles |
1.00 |
ML-DSA-65 sign |
594911 cycles |
594232 cycles |
1.00 |
ML-DSA-65 verify |
194945 cycles |
194830 cycles |
1.00 |
ML-DSA-87 keypair |
324392 cycles |
324689 cycles |
1.00 |
ML-DSA-87 sign |
759983 cycles |
759724 cycles |
1.00 |
ML-DSA-87 verify |
320332 cycles |
321079 cycles |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
oqs-bot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Graviton3 (no-opt)
Details
| Benchmark suite | Current: 9d18dcd | Previous: 8016262 | Ratio |
|---|---|---|---|
ML-DSA-44 keypair |
138947 cycles |
138845 cycles |
1.00 |
ML-DSA-44 sign |
493274 cycles |
492563 cycles |
1.00 |
ML-DSA-44 verify |
148633 cycles |
148607 cycles |
1.00 |
ML-DSA-65 keypair |
242553 cycles |
242393 cycles |
1.00 |
ML-DSA-65 sign |
804660 cycles |
804647 cycles |
1.00 |
ML-DSA-65 verify |
240700 cycles |
241236 cycles |
1.00 |
ML-DSA-87 keypair |
396523 cycles |
397303 cycles |
1.00 |
ML-DSA-87 sign |
1027936 cycles |
1027738 cycles |
1.00 |
ML-DSA-87 verify |
402309 cycles |
402404 cycles |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
oqs-bot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Graviton2 (no-opt)
Details
| Benchmark suite | Current: 9d18dcd | Previous: 8016262 | Ratio |
|---|---|---|---|
ML-DSA-44 keypair |
214279 cycles |
213674 cycles |
1.00 |
ML-DSA-44 sign |
780438 cycles |
780502 cycles |
1.00 |
ML-DSA-44 verify |
229510 cycles |
229899 cycles |
1.00 |
ML-DSA-65 keypair |
382506 cycles |
381300 cycles |
1.00 |
ML-DSA-65 sign |
1295279 cycles |
1281568 cycles |
1.01 |
ML-DSA-65 verify |
372570 cycles |
371578 cycles |
1.00 |
ML-DSA-87 keypair |
607871 cycles |
605663 cycles |
1.00 |
ML-DSA-87 sign |
1617917 cycles |
1616413 cycles |
1.00 |
ML-DSA-87 verify |
617475 cycles |
617335 cycles |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Arm Cortex-A55 (Snapdragon 888) benchmarks (no-opt)
Details
| Benchmark suite | Current: 9d18dcd | Previous: 8016262 | Ratio |
|---|---|---|---|
ML-DSA-44 keypair |
467958 cycles |
467905 cycles |
1.00 |
ML-DSA-44 sign |
2224832 cycles |
2228525 cycles |
1.00 |
ML-DSA-44 verify |
550511 cycles |
549869 cycles |
1.00 |
ML-DSA-65 keypair |
784723 cycles |
786781 cycles |
1.00 |
ML-DSA-65 sign |
3617759 cycles |
3618397 cycles |
1.00 |
ML-DSA-65 verify |
853323 cycles |
854890 cycles |
1.00 |
ML-DSA-87 keypair |
1265333 cycles |
1268342 cycles |
1.00 |
ML-DSA-87 sign |
4467854 cycles |
4484363 cycles |
1.00 |
ML-DSA-87 verify |
1375267 cycles |
1370947 cycles |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SpacemiT K1 8 (Banana Pi F3) benchmarks (no-opt)
Details
| Benchmark suite | Current: 9d18dcd | Previous: 8016262 | Ratio |
|---|---|---|---|
ML-DSA-44 keypair |
830603 cycles |
830046 cycles |
1.00 |
ML-DSA-44 sign |
3346223 cycles |
3341775 cycles |
1.00 |
ML-DSA-44 verify |
922954 cycles |
921764 cycles |
1.00 |
ML-DSA-65 keypair |
1413127 cycles |
1413662 cycles |
1.00 |
ML-DSA-65 sign |
5443100 cycles |
5446904 cycles |
1.00 |
ML-DSA-65 verify |
1477412 cycles |
1476905 cycles |
1.00 |
ML-DSA-87 keypair |
2318420 cycles |
2315400 cycles |
1.00 |
ML-DSA-87 sign |
6836580 cycles |
6814386 cycles |
1.00 |
ML-DSA-87 verify |
2407595 cycles |
2407487 cycles |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Arm Cortex-A72 (Raspberry Pi 4) benchmarks (opt)
Details
| Benchmark suite | Current: 9d18dcd | Previous: 8016262 | Ratio |
|---|---|---|---|
ML-DSA-44 keypair |
224054 cycles |
228813 cycles |
0.98 |
ML-DSA-44 sign |
620346 cycles |
649903 cycles |
0.95 |
ML-DSA-44 verify |
221914 cycles |
231691 cycles |
0.96 |
ML-DSA-65 keypair |
392934 cycles |
396875 cycles |
0.99 |
ML-DSA-65 sign |
1047912 cycles |
1042659 cycles |
1.01 |
ML-DSA-65 verify |
374798 cycles |
381091 cycles |
0.98 |
ML-DSA-87 keypair |
649166 cycles |
655087 cycles |
0.99 |
ML-DSA-87 sign |
1350109 cycles |
1386308 cycles |
0.97 |
ML-DSA-87 verify |
632785 cycles |
634533 cycles |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Arm Cortex-A72 (Raspberry Pi 4) benchmarks (no-opt)
Details
| Benchmark suite | Current: 9d18dcd | Previous: 8016262 | Ratio |
|---|---|---|---|
ML-DSA-44 keypair |
321417 cycles |
300425 cycles |
1.07 |
ML-DSA-44 sign |
1235499 cycles |
1168761 cycles |
1.06 |
ML-DSA-44 verify |
343660 cycles |
326089 cycles |
1.05 |
ML-DSA-65 keypair |
591258 cycles |
569323 cycles |
1.04 |
ML-DSA-65 sign |
2002331 cycles |
1958929 cycles |
1.02 |
ML-DSA-65 verify |
553496 cycles |
540154 cycles |
1.02 |
ML-DSA-87 keypair |
879571 cycles |
866154 cycles |
1.02 |
ML-DSA-87 sign |
2538235 cycles |
2470247 cycles |
1.03 |
ML-DSA-87 verify |
898851 cycles |
880831 cycles |
1.02 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Arm Cortex-A72 (Raspberry Pi 4) benchmarks (no-opt)'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.03.
| Benchmark suite | Current: 9d18dcd | Previous: 8016262 | Ratio |
|---|---|---|---|
ML-DSA-44 keypair |
321417 cycles |
300425 cycles |
1.07 |
ML-DSA-44 sign |
1235499 cycles |
1168761 cycles |
1.06 |
ML-DSA-44 verify |
343660 cycles |
326089 cycles |
1.05 |
ML-DSA-65 keypair |
591258 cycles |
569323 cycles |
1.04 |
This comment was automatically generated by workflow using github-action-benchmark.
mkannwischer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Hanno for pushing this over the line! LGTM.
9d18dcd to
3042b75
Compare
This has negligible impact on performance while improving readability and provability. For now, we still declassify the result of the verification, but this may be further improved in the future. Signed-off-by: Hanno Becker <beckphan@amazon.co.uk>
3042b75 to
39eec80
Compare
This has negligible impact on performance while improving readability and provability.
For now, we still declassify the result of the verification, but this may be further improved in the future.