Sign stack usage: Re-use y/h buffer #800
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkannwischer
force-pushed
the
sign-stack-yh
branch
from
f2ed6f4 to
1c6a96e
Compare
Contributor
Author
|
CBMC runtime for ML-DSA-87 increases from 11 minutes to 25 minutes :( |
Contributor
|
@mkannwischer To double-check: Can you try adding a helper function which takes the pointers to the helper structures (incl. |
mkannwischer
force-pushed
the
sign-stack-yh
branch
4 times, most recently
from
283b8b5 to
d725be5
Compare
Signed-off-by: Matthias J. Kannwischer <matthias@kannwischer.eu>
mkannwischer
force-pushed
the
sign-stack-yh
branch
from
d725be5 to
461dd7a
Compare
This commit is the second commit working towards bringing down the memory consumption of signature_internal. It combines the y and h buffer as those lifetime does not overlap. Signed-off-by: Matthias J. Kannwischer <matthias@kannwischer.eu>
Signed-off-by: Hanno Becker <beckphan@amazon.co.uk>
Signed-off-by: Hanno Becker <beckphan@amazon.co.uk>
hanno-becker
force-pushed
the
sign-stack-yh
branch
from
461dd7a to
7f55450
Compare
This was referenced Dec 25, 2025
Contributor
Author
|
We merged #818 instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit is the second commit working towards bringing down the memory consumption of signature_internal. It combines the y and h buffer as those lifetime does not overlap.
crypto_sign_signature_internalstack usage #791-fstack-usageofsignature_internalof ML-DSA-86 reduces from 121536 to 114368 (aarch64, -Os, gcc14).