Update sknet.py #10
Open
Update sknet.py #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I changed two parts. The one is the way to concatenate features in Skconv Module, I used list implemented in python and concatenated after iteration. It is more faster than previous way. To check the details, refer to [this issue](pytorch/vision#1260 (comment)). Another one is the function for pooling, AvgPool2d( ), it depends on the input tensor size, but AdaptiveAvgPool2d( ) can process all inputs that have any size.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @pppLang
Thank you for sharing great works!
I changed two parts. The one is the way to concatenate features in Skconv Module, I used list implemented in python and concatenated features by using torch.cat( ) after iteration. It is faster than previous way. To check the details, refer to this issue.
Another one is the function for pooling, AvgPool2d( ), it depends on the input tensor size, but AdaptiveAvgPool2d( ) can process all inputs that have any size.