Skip to content

Conversation

@vaexe-eve
Copy link

@vaexe-eve vaexe-eve commented Oct 19, 2025

Description

This change adds a new filter. Happy to rename the filter if you think naming it SharingFilter or something would be more descriptive. SharedFilter just seemed like a weird name.

I've not done much work on auth plugins, so if there's any problems please let me know and I'll fix them up.

Fixes #96

Type of Change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality not to work as expected)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have checked my code and corrected any misspellings

@vaexe-eve vaexe-eve requested a review from ppfeufer as a code owner October 19, 2025 13:35
@ppfeufer
Copy link
Owner

ppfeufer commented Oct 19, 2025

Hey there, thanks for taking a crack at this.
However, some remarks:

  • VisibilityFilter might not be the best name. SharedCharacterFilter or something along those lines might be better. Basically, a name that reflects what this filter does.
  • Reverse logic, as the only setting in the model, is not really intuitive. Like, what logic are we reversing here? A simple dropdown selection, like "Has characters shared with recruiters: Yes/No", would be better and make the reverse logic checkbox obsolete.
  • Please run pre-commit before committing …

@vaexe-eve
Copy link
Author

Ah sorry, I missed that part of the docs (pre-commit). I'll sort all of that out. 👍

@ppfeufer
Copy link
Owner

Any updates on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request] Visibility filter

2 participants