Add the depndency checking in install-sh script
#13
Conversation
|
Sorry for the late reply. It's looks really great !! |
|
Yes, it means configuration. Prefixing names with CFG is because we could generate config.mk from the script accordingly, then Makefile could simply include config.mk. That would grant us basic portability. They are not configuration variables for the script, but for the Makefile. |
before configuring
|
Hi, @MnO2 , I pulled it locally and found that commit /usr/bin/ld: cannot find -lpbar
/usr/bin/ld: cannot find -lcumatrix
collect2: error: ld returned 1 exit status
make: *** [bin/nn-train] Error 1 |
|
yeah, it is incorrect. I didn't realize that all of my master commits would be linked to this pull request. I would fix it asap. |
required information - Note: I am aware of the downside of git submodule: https://codingkilledthecat.wordpress.com/2012/04/28/why-your-company-shouldnt-use-git-submodules/ . However, in this case it is only used for a RDONLY installation replica. Git submodule should be fine and light weight for this use case.
|
@botonchou : I've tested on my Macbook Pro with Yosemite and g2.2xlarge with Ubuntu 14.04. Both building process looks fine now. |
|
I'd like to keep it simple, user-friendly and lightweight, but have no idea how it can be achieve (at the same time) with those dependency checking and the configuration stuff. Maybe we can figure something out together. |
|
First, we have to define it is simple to library developer or library user. When you are saying user-friendly, I suppose you are referring to library user. As long as we have .deb, .rpm or homebrew stub. Library user would not have to figure these things by themselves. They would just simply run "brew install" or "apt-get install". As long as we have could command line options for nn-train etc., it is not a problem. Configuration script is unavoidable when you would build it in different environment. Especially when you would like to port it to Windows. If you are ambitious enough and would like make this library as popular as libsvm, this is a ugliness where library developers have to deal with. |
|
Sure, I like the configuration scripts and I know it's unavoidable if I want to port it to windows. |
|
For open source I've involved so far. A way to let junior developers have things to do is to establish a guide there. Mark different task with their difficulty and guide them to do that. Like: https://github.com/rust-lang/rust/wiki/Note-guide-for-new-contributors |
|
Yeah, that makes sense. Why didn't I think of that before XDD |
2 participants
Resolve Issuse #12.