-
Notifications
You must be signed in to change notification settings - Fork 94
chore!: upgrade chokidar to v4 #503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
cc @ai |
|
cc @RyanZim |
|
Is there some pressing need to upgrade from v3? If not, we might as well wait until we're working on the next major release, and then upgrade to v5 directly. |
They have remove the glob support, but we have handle it in first |
|
Seems that the removal of glob support actually breaks things; tests are failing. |
|
@RyanZim, i send the commit that i want to try in CI. |
|
@RyanZim, all tests run successfully 🥳 |
|
Two problems with this approach:
|
|
Maybe close this @RyanZim? |
Like #501, but to
v4.chokidarversion 4 and up now only have 1 dependency, which is can make the install size is smaller and faster. But if you want tov5like #501, we must drop Nodejsv18and only supportv20.19.