Add flags for charts to deploy on k3s/rke2 clusters#329
Open
dahuang-purestorage wants to merge 3 commits intomasterfrom
Open
Add flags for charts to deploy on k3s/rke2 clusters#329dahuang-purestorage wants to merge 3 commits intomasterfrom
dahuang-purestorage wants to merge 3 commits intomasterfrom
Conversation
Signed-off-by: dahuang <dahuang@purestorage.com>
zoxpx
reviewed
Jan 19, 2022
Contributor
zoxpx
left a comment
zoxpx
left a comment
There was a problem hiding this comment.
I'd suggest you isolate the needed expression as a variable:
{{- $isK3s := .Capabilities.KubeVersion.GitVersion | toString | regexFind "(k3s|rke2)" }}
... and use the variable in {{ if... }} expressions.
Signed-off-by: dahuang <dahuang@purestorage.com>
Signed-off-by: dahuang <dahuang@purestorage.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: dahuang dahuang@purestorage.com
What this PR does / why we need it:
Current charts fails to deploy on k3s cluster with issues on CSI charts. This PR adds the missing sock and annotation for successfully deployment.
Which issue(s) this PR fixes (optional)
Closes #
It doesn't fix any PR but it's related work to PWX-21842
Special notes for your reviewer:
Testing notes:
helm install --debug --namespace kube-system --generate-name .on k3s cluster.