Added functions to help calculate tier fractions #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
POOL-1918 Make it easy to calculate more human prize tiers
People express prize tiers as: 2500, 800, 400 etc. We need a lib to help with that |
PierrickGT
suggested changes
Dec 20, 2021
Comment on lines
+19
to
+23
| (tot: BigNumber, tierPrize: BigNumber, index: number): BigNumber => { | ||
| return tot.add( | ||
| tierPrize.mul(calculateNumberOfPrizesForIndex(bitRangeSize, index)) | ||
| ); | ||
| }, |
Contributor
There was a problem hiding this comment.
tot is the total right? Would be more explicit in full.
Suggested change
| (tot: BigNumber, tierPrize: BigNumber, index: number): BigNumber => { | |
| return tot.add( | |
| tierPrize.mul(calculateNumberOfPrizesForIndex(bitRangeSize, index)) | |
| ); | |
| }, | |
| (total: BigNumber, tierPrize: BigNumber, index: number): BigNumber => { | |
| return total.add( | |
| tierPrize.mul(calculateNumberOfPrizesForIndex(bitRangeSize, index)) | |
| ); | |
| }, |
| tierPrize.mul(calculateNumberOfPrizesForIndex(bitRangeSize, index)) | ||
| ); | ||
| }, | ||
| ethers.BigNumber.from("0") |
Contributor
There was a problem hiding this comment.
Not needed and this way we can also remove the ethers import.
Suggested change
| ethers.BigNumber.from("0") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.