Skip to content

Conversation

@puppywang
Copy link

Description:

This PR addresses an issue where the extension's functionality (playback speed and filters) remained active on blacklisted sites even when the icon correctly indicated an inactive state (turned gray). It also improves the URL matching user experience.

Key Changes:

  • Enforce Blacklist in Content Scripts: Added urlMode checks in ConfigSync.ts. Now, playback speed adjustments, effect synchronization, and the circle widget are completely disabled when the current URL is blacklisted.
  • Improved URL Matching: Enhanced the testURLWithPart utility to support domain-based matching without requiring explicit protocol prefixes (e.g., example.com correctly matches http://example.com).
  • Real-time Icon Awareness: Integrated keybindsUrlCondition into the background badge.ts watchers. The extension icon now updates its state immediately upon tab switching or rule modification.
  • Code Optimization: Unified the site activity logic using the isActiveOnSite state and removed obsolete debug logs.
    Verified on live.bilibili.com: the speed control no longer responds when the site is blacklisted, consistent with the gray icon state.

Any commet is welcomed.

- Fix: disabled playback speed and effects on blacklisted URLs in ConfigSync.ts\n- Update: enhanced URL matching in configUtils.ts to support input without protocol prefixes\n- Improve: dynamic icon status updates on tab switch via badge.ts watchers\n- Refactor: cleaned up debug logs and unified site activity checks
@polywock
Copy link
Owner

polywock commented Jan 16, 2026

Extension's functionality (playback speed and filters) remained active on blacklisted sites even when the icon correctly indicated an inactive state (turned gray)

Hello! At least for me, turning off Global Speed using the power icon or a URL rule set to Off turns off speed control, filters, circle widget. So I'm slightly confused here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants