added Bucket Model #1
Conversation
There was a problem hiding this comment.
Missing some implementations on buckets
Missing code coverage on bucket
polystorage/bucket/bucket.py needs to become polystorage/models.py (can also become polystorage/models/bucket.py and being imported into polystorage/models/__init__.py)
polystorage package needs to become a django app
Coverage needs to be set up as a django code coverage system
polystorage/main.py needs to disappear
test_settings should be created
Code coverage should import all files in polystorage folder
| super().save(*args, **kwargs) # Save first to get the ID | ||
|
|
||
| if is_new: | ||
| self.create_associated_bucket_instance() |
There was a problem hiding this comment.
Move the super().save() after this line to avoid desynchronized databases
polystorage/models/bucket.py
Outdated
| } | ||
|
|
||
| self.root_path = generated_root_path | ||
| self.save(update_fields=['root_path']) |
There was a problem hiding this comment.
Remove self.save() for the same reasons
polystorage/models/bucket.py
Outdated
| random_folder = uuid.uuid4().hex[:8] | ||
| # Use the INSTANCES_MAIN_FOLDER setting as the base directory | ||
| base_folder = settings.INSTANCES_MAIN_FOLDER | ||
| # Construct the full root path | ||
| generated_root_path = os.path.join(base_folder, random_folder) |
There was a problem hiding this comment.
The root path should be generated on the cluster, and returned in the json response
No description provided.