Runtime Restriction of Benchmark Methods#27
Open
MatthiasMolitor wants to merge 7 commits intopolyfractal:masterfrom
Open
Runtime Restriction of Benchmark Methods#27MatthiasMolitor wants to merge 7 commits intopolyfractal:masterfrom
MatthiasMolitor wants to merge 7 commits intopolyfractal:masterfrom
Conversation
…e result (in combination with runtime restriction)
Contributor
Author
|
@polyfractal Any chance to get this merged? |
Owner
|
@gabrielsch ^^^^ ? I've largely stepped aside as maintainer of this library and given it over to @gabrielsch . Unless he has some objections, it LGTM from a casual skim and I'll merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change introduces a new (optional) annotation
@maxRuntime, which allows one to restrict the runtime of a benchmark method to a specified number of seconds.This is useful, if a benchmark is executed on different hardware or if a generic event is used to benchmark several implementations with really different performance characteristics.
In these cases, you might want to stop a benchmark early instead of waiting for hours until the results of a slow system are available.
In the following example, the benchmark method
slowIndexingAlgo()is stopped once 10000 iterations are reached or if the runtime of 5 minutes (300 seconds) is exceeded: