Closing issue #18#19
Open
davidsteinsland wants to merge 1 commit intopolyfractal:masterfrom
davidsteinsland:feature-callback-arguments
Open
Closing issue #18#19davidsteinsland wants to merge 1 commit intopolyfractal:masterfrom davidsteinsland:feature-callback-arguments
davidsteinsland wants to merge 1 commit intopolyfractal:masterfrom
davidsteinsland:feature-callback-arguments
Conversation
Owner
|
Hey, sorry for the delay on this. I was traveling when the PR came in and then just plain forgot about it. I'm in agreement about making the methods
Not saying I'm against these changes, just trying to get an understanding how they will be used. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also fixing bug with division by zero in
MethodResults.This will introduce a new method API, so users should update their method signatures before using this patch.