BooksCollector и тесты #5
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ayantea1
reviewed
Sep 23, 2025
| from books_collector import BooksCollector | ||
|
|
||
|
|
||
| @pytest.fixture |
There was a problem hiding this comment.
Можно улучшить: фикстуры стоит хранить в отдельном модуле
Ayantea1
reviewed
Sep 23, 2025
test_books_collector.py
Outdated
| collector.add_new_book("Книга") | ||
| collector.set_book_genre("Книга", genre) | ||
| expected = genre if should_set else "" | ||
| assert collector.get_book_genre("Книга") == expected |
There was a problem hiding this comment.
Нужно исправить: Нужно исправить: для get_book_genre должен быть отдельный тест. Тесты не должны дублировать друг друга. В идеале - чтобы в каждом тесте использовался только один проверяемый метод, все остальное можно получить прямым доступом к словарям и спискам
Ayantea1
reviewed
Sep 23, 2025
| collector.add_new_book("Гарри Поттер") | ||
| collector.add_book_in_favorites("Гарри Поттер") | ||
| result = collector.get_list_of_favorites_books() | ||
| assert isinstance(result, list) |
There was a problem hiding this comment.
Нужно исправить: тест не отличается от test_add_book_in_favorites_adds_once. Установи значение избранного напрямую или иначе проверь состояние списка в тесте добавления
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.