Fix (issuse: #104) : Cast error when 'set password'#112
Fix (issuse: #104) : Cast error when 'set password'#112joeCarf wants to merge 3 commits intopolardb:mainfrom
Conversation
|
@Oldbread3 PTAL:) |
|
Will this fix cause exception for statement like |
|
Amend use name at code path below might be the proper way to fix this issue. |
when using statement should i just cast SQLIdentifierExpr to MySqlUserName in MysqlStatementParser.class (code path above) or or use |
| (SQLSetStatement) FastsqlUtils.parseSql(sql, SQLParserFeature.IgnoreNameQuotes).get(0); | ||
| SQLAssignItem assignItem = statement.getItems().get(0); | ||
| MySqlUserName userName = (MySqlUserName) assignItem.getTarget(); | ||
| SQLExpr target = assignItem.getTarget(); |
There was a problem hiding this comment.
I think this might be a more safe way to fix this issue, cause it did't change parseSet() function in MysqlStatementParser, and won't affect other using scenario. PTAL:) @Oldbread3
| (SQLSetStatement) FastsqlUtils.parseSql(sql, SQLParserFeature.IgnoreNameQuotes).get(0); | ||
| SQLAssignItem assignItem = statement.getItems().get(0); | ||
| MySqlUserName userName = (MySqlUserName) assignItem.getTarget(); | ||
| SQLExpr target = assignItem.getTarget(); |
|
这个pr还不能合入嘛 @Oldbread3 @ZSYTY |
89ea352 to
ba432af
Compare
Problems solved in this PR
issuse: #104
Changes proposed in this PR
Tests
Release note