Add ForCommand #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
podkolzzzin
requested changes
Jun 21, 2022
Owner
podkolzzzin
left a comment
podkolzzzin
left a comment
There was a problem hiding this comment.
It seems to me to create for command using while command would be more elegant solution and will allow to get rid of code duplication
Author
I made while command using for command. I think that this way more elegant than vice versa. |
podkolzzzin
reviewed
Jul 1, 2022
| new JumpCommand() | ||
| }) | ||
| .ToArray(); | ||
| var ifCommandsCount = new IfCommand(_condition, realBody.ToArray(), Array.Empty<ICommand>()).Compile().Count() - 3; |
Owner
There was a problem hiding this comment.
It's quite complex logic and you are duplicating it.
Let's reuse code from WhileCommand
podkolzzzin
requested changes
Jul 1, 2022
Owner
podkolzzzin
left a comment
podkolzzzin
left a comment
There was a problem hiding this comment.
Let's reuse code from a WhileCommand
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.