separate xlive project into different project and lib files #968
+9,499
−5,651
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Berthalamew
force-pushed
the
lib
branch
3 times, most recently
from
a4d6902 to
e366180
Compare
Collaborator
|
It's fine by me but you should've kept any refactoring out of this PR, like the type changes unless they were really necessary |
Collaborator
Author
|
Pretty much all of the refactoring was necessary to split things up and avoid including things in places they shouldn't be. |
Berthalamew
force-pushed
the
lib
branch
2 times, most recently
from
01af4d4 to
42171db
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.