Skip to content

FIx for issue with default values #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
remorse wants to merge 1 commit into
base: master
Choose a base branch
from
Open

FIx for issue with default values #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 16 additions & 5 deletions lib/HTML/StickyForm.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -345,7 +345,7 @@ sub text{
delete $args->{default};
}else{
$value=delete $args->{default};
$value=$self->{req}->param($name) if $self->{params};
$value=$self->{req}->param($name) if $self->_has_sticky_value($name);
}

_escape($type);
Expand Down Expand Up @@ -412,7 +412,7 @@ sub textarea{
delete $args->{default};
}else{
$value=delete $args->{default};
$value=$self->{req}->param($name) if $self->{params};
$value=$self->{req}->param($name) if $self->_has_sticky_value($name);
}

_escape($name);
Expand Down Expand Up @@ -461,7 +461,7 @@ sub checkbox{
}else{
$checked=delete $args->{default};
$value='' unless defined($value);
$checked=grep $_ eq $value,$self->{req}->param($name) if $self->{params};
$checked=grep $_ eq $value,$self->{req}->param($name) if $self->_has_sticky_value($name);
}

_escape($name);
Expand Down Expand Up @@ -537,7 +537,7 @@ sub checkbox_group{
$checked=delete $args->{default};
$checked=[$checked] if ref($checked) ne 'ARRAY';
}
$checked=[$self->{req}->param($name)] if $self->{params};
$checked=[$self->{req}->param($name)] if $self->_has_sticky_value($name);
}
my %checked=map +($_,'checked'),@$checked;
my $br=delete $args->{linebreak} ? "<br$self->{well_formed}>" : '';
Expand Down Expand Up @@ -665,7 +665,7 @@ sub select{
delete $args->{default};
}else{
$selected=delete $args->{default};
$selected=[$self->{req}->param($name)] if $self->{params};
$selected=[$self->{req}->param($name)] if $self->_has_sticky_value($name);
}
if(!defined $selected){ $selected=[]; }
elsif(ref($selected) ne 'ARRAY'){ $selected=[$selected]; }
Expand Down Expand Up @@ -767,6 +767,17 @@ sub _args{
($self,$args);
}

=item _has_sticky_value($name)

Return true if there is a provided sticky value.

=cut

sub _has_sticky_value($) {
my $self=shift;
($self->{params} && defined($self->{req}->param($_[0])));
}

=item _select_options(\@values,\%option_args,\%labels,$values_as_labels)

Returns an HTML fragment containing C<option> elements for the supplied
Expand Down