Refactor to use clap's built-in env attribute for environment variables #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit replaces all ad-hoc environment variable handling with clap's built-in `env` attribute. The changes include: - Add hidden global parameters --log-level and --execution-mode that read from their respective environment variables - Update all command arguments to use the env attribute: - VerifyArgs: guide uses AGENTIC_NAVIGATION_GUIDE_PATH, root uses AGENTIC_NAVIGATION_GUIDE_ROOT - CheckArgs: guide uses AGENTIC_NAVIGATION_GUIDE_PATH - DumpArgs: root uses AGENTIC_NAVIGATION_GUIDE_ROOT - InitArgs: root uses AGENTIC_NAVIGATION_GUIDE_ROOT - Remove all manual std::env::var() calls for these parameters - Implement proper conflict resolution between convenience flags and direct parameters - Preserve AGENTIC_NAVIGATION_GUIDE_NAME fallback logic as a special case This makes the code cleaner, more maintainable, and leverages clap's built-in functionality for better consistency. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Update --post-tool-use-hook and --pre-commit-hook to properly conflict with both --execution-mode AND each other using conflicts_with_all. This ensures mutually exclusive usage of these execution mode options. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
envattributestd::env::var()calls throughout the codebaseChanges
Added hidden global parameters
--log-level: Reads fromAGENTIC_NAVIGATION_GUIDE_LOG_MODE(values: quiet, default, verbose)--execution-mode: Reads fromAGENTIC_NAVIGATION_GUIDE_EXECUTION_MODE(values: default, post-tool-use, pre-commit-hook)Updated command arguments
guideparameter now usesenv = "AGENTIC_NAVIGATION_GUIDE_PATH"rootparameter now usesenv = "AGENTIC_NAVIGATION_GUIDE_ROOT"guideparameter now usesenv = "AGENTIC_NAVIGATION_GUIDE_PATH"rootparameter now usesenv = "AGENTIC_NAVIGATION_GUIDE_ROOT"rootparameter now usesenv = "AGENTIC_NAVIGATION_GUIDE_ROOT"Implementation details
std::env::var()calls for the above parameters--verbose,--quiet) and the hidden--log-levelparameterAGENTIC_NAVIGATION_GUIDE_NAMEfallback logic as a special caseCli::build_config()to use the new parameter-based approachTesting
cargo fmtandcargo clippy -- -D warningsBenefits
🤖 Generated with Claude Code