Skip to content

Conversation

@ssynical
Copy link
Contributor

i did some stuff and i hav eno idea where to put type fdeifnutions so have fun with that thanks for the opportunity and i have not made a major and continuous lapse in my judgement yet

Copy link
Contributor Author

@ssynical ssynical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this branch has no conflicts with the base branch, just by the way

Copy link
Contributor Author

@ssynical ssynical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you know that thisbranch has no conflicts with the base branch

Copy link
Contributor Author

@ssynical ssynical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you were worried about this branch having conflicts with the base branch worry no longer

Copy link
Contributor Author

@ssynical ssynical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh yeah i forgot to mention that this branch has no conflicts with the base branch

Copy link
Contributor Author

@ssynical ssynical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checkout 'main' git pull --rebase

@plusgiant5
Copy link
Owner

Have you compiled it yet?

@ssynical
Copy link
Contributor Author

Update;

Firstly, the way that I was dealing with the includes was directly referencing Luau unlike the rest of the plugins. This has been refactored and will be reflected in the PR. There are a few more kinks that I had ironed out, such the errors, because luaL_error() doesn't actually return, it throws a Lua error which jumps out of the current function and that was being detected by the compiler. I fixed it by adding a return 0; which hopefully won't ever execute, but just to appease the compiler and to handle the case where (in some theoretical implementation) luaL_error() might actually return. There will be updates to the PR shortly.

Copy link
Contributor Author

@ssynical ssynical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated. Don't worry; this pull request branch does not conflict with the base branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants