Validate py314 compatibility #793
Conversation
CoMPaTech
added
github_actions
|
Warning Rate limit exceeded@CoMPaTech has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 0 minutes and 31 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (1)
WalkthroughBump default/supported Python from 3.13 to 3.14 across CI and tooling; add Python 3.14 to the test matrix; increment workflow cache versions; change Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant Runner as GitHub Actions Runner
participant CacheJob as cache job
participant MatrixJob as matrix test job
rect #EEF8F2
Note right of CacheJob: Compute global/hash-only cache key\nOutputs: cache-key, python-version
end
CacheJob-->>Runner: outputs.cache-key\noutputs.python-version
rect #FFF8E6
Note right of MatrixJob: Restore uses suffixed key:\n"${{ needs.cache.outputs.cache-key }}-{{ needs.cache.outputs.python-version }}"\nActivate `. venv-<python-version>/bin/activate`
end
MatrixJob->>CacheJob: request restore with suffixed key
Runner->>MatrixJob: prepare venv, run tests for matrix.python-version
MatrixJob->>Runner: on miss create cache (pytest restore uses fail-on-miss: false)
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/verify.yml(10 hunks)
🧰 Additional context used
🧠 Learnings (1)
📓 Common learnings
Learnt from: CoMPaTech
PR: plugwise/python-plugwise#656
File: .github/workflows/verify.yml:176-176
Timestamp: 2024-11-28T19:48:51.051Z
Learning: In this project, we align our supported Python versions with HA-core. When HA-core moves to a new Python version (e.g., Python 3.13), we update our testing matrix accordingly and discontinue testing for the previous version.
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Prepare
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.pre-commit-config.yaml (1)
2-3: Update the comment to match the new behavior.With
python: defaultwe no longer “force all unspecified python hooks to run python3”, so the comment is now misleading. Please adjust or remove it to avoid confusion.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.pre-commit-config.yaml(1 hunks)
🧰 Additional context used
🧠 Learnings (1)
📓 Common learnings
Learnt from: CoMPaTech
PR: plugwise/python-plugwise#656
File: .github/workflows/verify.yml:176-176
Timestamp: 2024-11-28T19:48:51.051Z
Learning: In this project, we align our supported Python versions with HA-core. When HA-core moves to a new Python version (e.g., Python 3.13), we update our testing matrix accordingly and discontinue testing for the previous version.
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Prepare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #793 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 21 21
Lines 3388 3388
=========================================
Hits 3388 3388 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Summary by CodeRabbit
New Features
Tests
Documentation
Chores