-
Notifications
You must be signed in to change notification settings - Fork 8
Implement fixes related to the select-platform-data provided to the HA Core integrations, part of solving pw-beta issue #897 #771
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
""" WalkthroughThe changes update how schedule-related fields are handled in fixture, source, and test data. Schedule keys are now always present with default values, and mode-related fields are conditionally included based on allowed modes. Test assertions and type annotations are adjusted to match these data structure changes. Changes
Sequence Diagram(s)sequenceDiagram
participant SourceData
participant DataBuilder
participant Consumer
SourceData->>DataBuilder: Provide device/zone data
DataBuilder->>DataBuilder: Initialize available_schedules = []\nselect_schedule = None
alt Schedules available
DataBuilder->>DataBuilder: Update keys with actual schedules and selection
end
DataBuilder->>Consumer: Return data with consistent schedule keys
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #771 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 21 21
Lines 3382 3388 +6
=========================================
+ Hits 3382 3388 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|



Summary by CodeRabbit
New Features
Bug Fixes
Tests
Chores