Skip to content

Conversation

@cdce8p
Copy link
Contributor

@cdce8p cdce8p commented Apr 10, 2025

Setuptools v77 added support for PEP 639 license expressions.

Summary by CodeRabbit

  • Chores
    • Simplified the project's licensing metadata by directly specifying the MIT license.
    • Updated the metadata categorization to streamline information presentation.

@cdce8p cdce8p requested a review from a team as a code owner April 10, 2025 23:59
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Apr 10, 2025

Walkthrough

The pull request updates the pyproject.toml file by simplifying the license declaration. The license reference has been changed from a file reference format to directly specifying the MIT license as a string. Additionally, the license classifier for "OSI Approved :: MIT License" has been removed, which may affect how the project is categorized in package indexes.

Changes

File Change Summary
pyproject.toml - Changed license declaration from license = {file = "LICENSE"} to license = "MIT".
- Removed the classifier "License :: OSI Approved :: MIT License".

Poem

In the code garden where changes bloom,
I hopped in to simplify the room.
License set as "MIT" so clear and bright,
With a classifier trimmed just right.
Hoppy days ahead in development light! 🐇


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between cea888f and 685f2d6.

📒 Files selected for processing (1)
  • pyproject.toml (1 hunks)
🔇 Additional comments (2)
pyproject.toml (2)

8-8: SPDX License Identifier Updated

The license declaration has been updated to use the SPDX license identifier "MIT", which is in line with Setuptools 77's support for PEP 639 license expressions. This change simplifies metadata and avoids referencing an external license file.


12-19: License Classifier Removal

The removal of the "License :: OSI Approved :: MIT License" classifier from the classifiers list is consistent with relying on the SPDX license field. Ensure that downstream tools or package indexes do not depend on the classifier for license discovery.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@sonarqubecloud
Copy link

Copy link
Contributor

@bouwew bouwew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM2!

@bouwew
Copy link
Contributor

bouwew commented Apr 11, 2025

@cdce8p should we bump the version after merging your two PR's?

@cdce8p
Copy link
Contributor Author

cdce8p commented Apr 11, 2025

@cdce8p should we bump the version after merging your two PR's?

That would be awesome, but not required.

@bouwew bouwew merged commit 72e217d into plugwise:main Apr 11, 2025
4 checks passed
@cdce8p cdce8p deleted the spdx-identifier branch April 11, 2025 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants