Skip to content

Test: fix double-use of version #720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bouwew merged 1 commit into from
Mar 2, 2025
+8 −8
Merged

Test: fix double-use of version #720

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions tests/test_init.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -342,18 +342,18 @@ async def connect(
assert smile._timeout == 30

# Connect to the smile
version = None
smile_version = None
try:
version = await smile.connect()
assert version is not None
smile_version = await smile.connect()
assert smile_version is not None
assert smile._timeout == 10
return server, smile, client
except (
pw_exceptions.ConnectionFailedError,
pw_exceptions.InvalidXMLError,
pw_exceptions.InvalidAuthentication,
) as exception:
assert version is None
assert smile_version is None
await self.disconnect(server, client)
raise exception

Expand Down Expand Up @@ -428,18 +428,18 @@ async def connect_legacy(
assert smile._timeout == 30

# Connect to the smile
version = None
smile_version = None
try:
version = await smile.connect()
assert version is not None
smile_version = await smile.connect()
assert smile_version is not None
assert smile._timeout == 30
return server, smile, client
except (
pw_exceptions.ConnectionFailedError,
pw_exceptions.InvalidXMLError,
pw_exceptions.InvalidAuthentication,
) as exception:
assert version is None
assert smile_version is None
await self.disconnect(server, client)
raise exception

Expand Down
Loading