Fix HA reloading

[bouwew]

Summary by CodeRabbit

• Documentation

  • Updated the changelog to include a new entry for a recently fixed issue.

• Refactor

  • Improved the unloading process for certain devices to streamline task cancellation.

• Chores

  • Updated the project version metadata.

[coderabbitai]

Walkthrough

The changelog was updated to document a new fix for issue #293. In the PlugwiseCircle node implementation, the unload method was modified to remove awaiting the completion of a canceled background task, now only calling cancel() on the task without awaiting its termination. The project version string in pyproject.toml was also updated.

Changes

File(s)	Change Summary
CHANGELOG.md	Added a new entry for a fix related to issue #293 under the "ONGOING" section.
plugwise_usb/nodes/circle.py	Modified PlugwiseCircle.unload: removed await after task cancellation, now only calls cancel().
pyproject.toml	Updated project version string from "0.44.8" to "0.44.8a98".

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant PlugwiseCircle

    User->>PlugwiseCircle: Call unload()
    PlugwiseCircle->>PlugwiseCircle: Cancel _retrieve_energy_logs_task (no await)
    PlugwiseCircle->>PlugwiseCircle: Save energy log records to cache
    PlugwiseCircle->>PlugwiseCircle: Call super().unload()

Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~6 minutes

Possibly related PRs

• Set to v0.44.8 release-version #294: Also updates the version string in pyproject.toml, but changes it from "0.44.8a8" to "0.44.8", showing related version management changes.

Suggested reviewers

• dirixmjm

Poem

A changelog note, a task set free,
Circle unloads with less decree.
No longer waits for logs to end,
Just cancels tasks and will not spend
More moments paused—so light, so spry,
The code hops on, a rabbit’s sigh!
🐇✨

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 271cd58 and bf04ea8.

📒 Files selected for processing (1)

• pyproject.toml (1 hunks)

✅ Files skipped from review due to trivial changes (1)

• pyproject.toml

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: Check commit

✨ Finishing Touches

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch fix-HA-reload-fail

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai generate unit tests to generate unit tests for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.92%. Comparing base (9629ca7) to head (bf04ea8).

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #299      +/-   ##
==========================================
- Coverage   80.93%   80.92%   -0.01%     
==========================================
  Files          36       36              
  Lines        7594     7593       -1     
==========================================
- Hits         6146     6145       -1     
  Misses       1448     1448              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud