-
Notifications
You must be signed in to change notification settings - Fork 2
Fully match version #288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fully match version #288
Conversation
WalkthroughThe changes update two GitHub Actions workflow files by removing the use of an intermediate variable for storing package versions fetched from PyPI and TestPyPI. Instead, the version existence check is now performed directly in the conditional statement using a streamlined command pipeline. Changes
Sequence Diagram(s)sequenceDiagram
participant Workflow
participant PyPI/TestPyPI
participant jq/grep
Workflow->>PyPI/TestPyPI: Fetch package versions (JSON)
PyPI/TestPyPI-->>Workflow: Return JSON data
Workflow->>jq/grep: Stream version keys and check for target version
jq/grep-->>Workflow: Return match result
Workflow->>Workflow: Decide to skip or publish based on result
Possibly related PRs
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (2)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #288 +/- ##
=======================================
Coverage 80.90% 80.90%
=======================================
Files 36 36
Lines 7584 7584
=======================================
Hits 6136 6136
Misses 1448 1448 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bouwew
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested working in python-plugwise github
Fix for issue plugwise-usb-beta issue #288



Fix release matching (also see plugwise/python-plugwise#772)
Summary by CodeRabbit