Skip to content

Conversation

@petschki
Copy link
Member

@mister-roboto
Copy link

@petschki thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

@petschki
Copy link
Member Author

@mauritsvanrees whats the desired maintenance branch here: 5.0.x or 5.x if we release this as 6.0.0 with PEP 420 for plone 6.2 ?

@mauritsvanrees
Copy link
Member

@mauritsvanrees whats the desired maintenance branch here: 5.0.x or 5.x if we release this as 6.0.0 with PEP 420 for plone 6.2 ?

That would be 5.x. I have created the branch and updated the sources of 6.0 and 6.1.

Copy link
Member

@mauritsvanrees mauritsvanrees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I have added some commits to move to a src-layout, and have removed the six dependency and an import other unittest2.

@mauritsvanrees mauritsvanrees merged commit 778a532 into master Nov 24, 2025
8 of 10 checks passed
@mauritsvanrees mauritsvanrees deleted the pep-420-native-namespace branch November 24, 2025 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants