Dev by hun756 · Pull Request #24 · pleyfy/Axrone

hun756 · 2025-10-24T15:05:14Z

No description provided.

Copilot

Pull Request Overview

This PR introduces a comprehensive WebGL2 rendering system with support for textures, shaders, materials, meshes, and batch rendering. The implementation provides a complete abstraction layer over WebGL2 with modern features including PBR materials, shader variants, and optimized batch rendering.

Key Changes

Complete WebGL2 texture system with format info, validation, and utilities
Advanced shader compilation and management with variant support and caching
Material system supporting Standard and PBR workflows with property management
Mesh/geometry system with vertex/index buffers and VAO management
Batch rendering system for optimized draw call reduction

Reviewed Changes

Copilot reviewed 37 out of 37 changed files in this pull request and generated 10 comments.

Show a summary per file

File	Description
packages/core/src/renderer/webgl2/texture/utils.ts	Texture utility classes for format handling, WebGL constants mapping, and validation
packages/core/src/renderer/webgl2/texture/texture.ts	Core WebGL texture implementation with mipmap generation and data upload
packages/core/src/renderer/webgl2/texture/sampler.ts	Texture sampler implementation with filtering and wrapping configuration
packages/core/src/renderer/webgl2/texture/manager.ts	Texture manager for creation, caching, and loading from files
packages/core/src/renderer/webgl2/shader/utils.ts	Shader utilities for type sizes, validation, and buffer layout
packages/core/src/renderer/webgl2/shader/compiler.ts	Shader compilation with variant support and validation
packages/core/src/renderer/webgl2/shader/material.ts	Material instance with property and keyword management
packages/core/src/renderer/webgl2/shader/manager.ts	Shader manager with caching and variant handling
packages/core/src/renderer/webgl2/mesh/utils.ts	Mesh utilities for layout validation and bounds calculation
packages/core/src/renderer/webgl2/material/standard-material.ts	Unity-style standard PBR material implementation
packages/core/src/renderer/webgl2/material/pbr-material.ts	glTF 2.0 compatible PBR material implementation
packages/core/src/renderer/webgl2/batch/batch-renderer.ts	Batch renderer for optimized instanced rendering

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot · 2025-10-24T15:06:59Z

web/packages/core/src/renderer/webgl2/texture/utils.ts

+    }
+
+    public static generateTextureId(): string {
+        return `tex_${Date.now()}_${Math.random().toString(36).substr(2, 9)}`;


The substr method is deprecated. Use substring or slice instead.

Suggested change

return `tex_${Date.now()}_${Math.random().toString(36).substr(2, 9)}`;

return `tex_${Date.now()}_${Math.random().toString(36).slice(2, 11)}`;

Copilot · 2025-10-24T15:06:59Z

web/packages/core/src/renderer/webgl2/texture/utils.ts

+        }
+
+        if (TextureFormatInfo.isInteger(format)) {
+


Empty if block should either be removed or contain a TODO comment explaining why it's intentionally empty.

Suggested change

// TODO: Handle integer format compatibility if needed in future.

Copilot · 2025-10-24T15:06:59Z

web/packages/core/src/renderer/webgl2/texture/utils.ts

+            const r = parseInt(hex.substr(0, 2), 16) / 255;
+            const g = parseInt(hex.substr(2, 2), 16) / 255;
+            const b = parseInt(hex.substr(4, 2), 16) / 255;
+            const a = hex.length === 8 ? parseInt(hex.substr(6, 2), 16) / 255 : 1;


The substr method is deprecated. Use substring or slice instead.

Suggested change

const r = parseInt(hex.substr(0, 2), 16) / 255;

const g = parseInt(hex.substr(2, 2), 16) / 255;

const b = parseInt(hex.substr(4, 2), 16) / 255;

const a = hex.length === 8 ? parseInt(hex.substr(6, 2), 16) / 255 : 1;

const r = parseInt(hex.slice(0, 2), 16) / 255;

const g = parseInt(hex.slice(2, 4), 16) / 255;

const b = parseInt(hex.slice(4, 6), 16) / 255;

const a = hex.length === 8 ? parseInt(hex.slice(6, 8), 16) / 255 : 1;

Copilot · 2025-10-24T15:07:00Z

web/packages/core/src/renderer/webgl2/texture/sampler.ts

+    }
+
+    private _generateSamplerId(): string {
+        return `sampler_${Date.now()}_${Math.random().toString(36).substr(2, 9)}`;


The substr method is deprecated. Use substring or slice instead.

Suggested change

return `sampler_${Date.now()}_${Math.random().toString(36).substr(2, 9)}`;

return `sampler_${Date.now()}_${Math.random().toString(36).substring(2, 11)}`;

Copilot · 2025-10-24T15:07:00Z

web/packages/core/src/renderer/webgl2/texture/sampler.ts

+
+        if (this.options.borderColor) {
+            const color = this.options.borderColor;
+


Empty if block should either be removed or contain a TODO comment explaining why border color configuration is not yet implemented.

Suggested change

// TODO: Border color configuration is not yet implemented.

// WebGL2 does not support sampler border color directly.

Copilot · 2025-10-24T15:07:00Z

web/packages/core/src/renderer/webgl2/texture/sampler.ts

+        }
+
+        if (this.options.lodBias !== undefined) {
+


Empty if block should either be removed or contain a TODO comment explaining why LOD bias configuration is not yet implemented.

Suggested change

// TODO: LOD bias configuration is not yet implemented.

Copilot · 2025-10-24T15:07:00Z

web/packages/core/src/renderer/webgl2/shader/shader-compilation-worker.ts

+        options?: { defines?: Record<string, any>; version?: string; precision?: string; }
+    ): Promise<string> {
+        return new Promise((resolve, reject) => {
+            const id = `${Date.now()}_${Math.random().toString(36).substr(2, 9)}`;


The substr method is deprecated. Use substring or slice instead.

Suggested change

const id = `${Date.now()}_${Math.random().toString(36).substr(2, 9)}`;

const id = `${Date.now()}_${Math.random().toString(36).slice(2, 11)}`;

Copilot · 2025-10-24T15:07:01Z

web/packages/core/src/renderer/webgl2/mesh/utils.ts

+    }
+
+    public static generateMeshId(): string {
+        return `mesh_${Date.now()}_${Math.random().toString(36).substr(2, 9)}`;


The substr method is deprecated. Use substring or slice instead.

Suggested change

return `mesh_${Date.now()}_${Math.random().toString(36).substr(2, 9)}`;

return `mesh_${Date.now()}_${Math.random().toString(36).slice(2, 11)}`;

Copilot · 2025-10-24T15:07:01Z

web/packages/core/src/renderer/webgl2/mesh/index-buffer.ts

+        this.bufferFactory = createBufferFactory(gl);
+        this._usage = config.usage || BufferUsage.STATIC_DRAW;
+        this._indexType = config.indexType || IndexType.UNSIGNED_SHORT;
+        this._id = `index_buffer_${Date.now()}_${Math.random().toString(36).substr(2, 9)}`;


The substr method is deprecated. Use substring or slice instead.

Suggested change

this._id = `index_buffer_${Date.now()}_${Math.random().toString(36).substr(2, 9)}`;

this._id = `index_buffer_${Date.now()}_${Math.random().toString(36).slice(2, 11)}`;

packages/core/src/renderer/webgl2/mesh/geometry.ts

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

…odules

hun756 added 11 commits October 23, 2025 16:42

Refactor EventScheduler to use PriorityQueue utility

c165ed9

Refactor ParticleSystemRenderer for SOA data layout

a57b696

Add ShaderCache for managing WebGL2 shader programs

9ae9a0c

Add WebGL2 material system core classes

e3ec7bf

Add WebGL2 texture management module

b1ea9a9

Add WebGL2 framebuffer abstraction

5199d00

Add WebGL2 mesh module with interfaces and utilities

3b69e95

Add WebGL2 geometry and index buffer implementations

93839de

Add WebGL2 batch rendering system

7dcc9c4

Remove ShaderCache class from WebGL2 renderer

0f61801

Add WebGL2 shader system core implementation

2d162a0

hun756 requested a review from Copilot October 24, 2025 15:05

Copilot AI reviewed Oct 24, 2025

View reviewed changes

hun756 and others added 17 commits October 24, 2025 20:56

Update packages/core/src/renderer/webgl2/mesh/geometry.ts

a65d48c

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Refactor IBindableTarget interface and update imports across WebGL2 m…

282532f

…odules

Add physics world type definitions

1768d14

Add physics primitive types and constants

a2b6076

Add physics body and shape type definitions

68b2292

Add physics types index file

18257a8

Add physics constraint and collision type definitions

a9fd999

Add ShapeManager2D for physics shape management

4f267cd

Add PhysicsWorld2D implementation

bc45815

Add circle-circle collision detection in Narrowphase2D

0b93375

Add initial IslandSolver2D implementation

5b8bb23

Add ContactManager2D for physics contact management

f92a9a8

Add 2D constraint manager implementation

cf22f25

Add BodyManager2D for physics body management

afad14c

Add DynamicAABBTree2D broadphase implementation

c5006b1

Remove readonly from IPhysicsProfiler properties

15712a4

Re-export contact manifold and point types

1d41807

hun756 added 30 commits January 25, 2026 16:10

Add tests for ShapeManager2D

b409e64

Refactor physics tests for new API usage

0a019fd

Relax test assertions in collision algorithm tests

b881e4f

Add basic tests for ConstraintSolver2D

3321b07

Refactor and simplify physics test suites

52207a4

Update setMassData calls with center of mass argument

b7f6cfe

Add legacy aliases and flexible shape definitions

cbb3a72

Add raycast types for 2D and 3D physics

3427875

Add raycast utility classes and functions

b608eb5

Add RaycastSystem2D and RaycastSystem3D classes

289b46a

Add 3D spatial hash grid and octree structures

e6e34fb

Add 2D and 3D raycast primitive intersection utilities

c4fb4bf

Add raycast optimization utilities for 2D and 3D physics

5b116ea

Add custom error classes for raycasting

fb586cd

Add initial raycast engine implementation

846fa35

Add continuous, adaptive, and priority raycasting utilities

64c5791

Add BoundingVolumeHierarchy with BVH construction and raycast

d844765

Add advanced 3D raycast and shape casting utilities

4b67f95

Refactor Octree implementation to use shared geometry module

250238f

Rename Octree to SpatialOctree in physics module

4178b96

fix: Remove unused IBarycentricCoords export

e651615

Add singleton core type definitions

dac165b

feat: Add singleton error handling utilities

9a7ed16

Add singleton registry implementation

10067be

Add singleton implementation classes

43713e5

Add singleton utilities and exports to utility package

2092f53

test: Add comprehensive tests for singleton implementations

db04490

Add singleton component support to World

f63e436

fix: Add componentMask property to Archetype class

5c64008

Move project into web/ directory

0040e38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

Dev#24

Dev#24
hun756 wants to merge 93 commits intopleyfy:devfrom
hun756:dev

hun756 commented Oct 24, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Oct 24, 2025

Uh oh!

Copilot AI Oct 24, 2025

Uh oh!

Copilot AI Oct 24, 2025

Uh oh!

Copilot AI Oct 24, 2025

Uh oh!

Copilot AI Oct 24, 2025

Uh oh!

Copilot AI Oct 24, 2025

Uh oh!

Copilot AI Oct 24, 2025

Uh oh!

Copilot AI Oct 24, 2025

Uh oh!

Copilot AI Oct 24, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

	return `tex_${Date.now()}_${Math.random().toString(36).substr(2, 9)}`;
	return `tex_${Date.now()}_${Math.random().toString(36).slice(2, 11)}`;


	// TODO: Handle integer format compatibility if needed in future.

	return `sampler_${Date.now()}_${Math.random().toString(36).substr(2, 9)}`;
	return `sampler_${Date.now()}_${Math.random().toString(36).substring(2, 11)}`;


		if (this.options.borderColor) {
		const color = this.options.borderColor;


	// TODO: Border color configuration is not yet implemented.
	// WebGL2 does not support sampler border color directly.

	const id = `${Date.now()}_${Math.random().toString(36).substr(2, 9)}`;
	const id = `${Date.now()}_${Math.random().toString(36).slice(2, 11)}`;

	return `mesh_${Date.now()}_${Math.random().toString(36).substr(2, 9)}`;
	return `mesh_${Date.now()}_${Math.random().toString(36).slice(2, 11)}`;

	this._id = `index_buffer_${Date.now()}_${Math.random().toString(36).substr(2, 9)}`;
	this._id = `index_buffer_${Date.now()}_${Math.random().toString(36).slice(2, 11)}`;

Comments

Conversation

hun756 commented Oct 24, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Key Changes

Reviewed Changes

Uh oh!

Copilot AI Oct 24, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 24, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 24, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 24, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 24, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 24, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 24, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 24, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 24, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant