Conversation
Create .gitmodules
init submodules
Change-Id: Id4bf54bb8da5cb3b98769809ad316f14101b0ff1
Change-Id: Id5696e9d827464c0bb572b56c0d25ce8da5b65e7
Change-Id: Ia2be82030b194d799eaf063ac925d37db36b1b43
luxufan
reviewed
May 22, 2022
Collaborator
luxufan
left a comment
luxufan
left a comment
There was a problem hiding this comment.
The unittests on abi still need to be added.
| } | ||
| break; | ||
| case llvm::CallingConv::C: | ||
| determineAPITypesForRISC_V(); |
Collaborator
There was a problem hiding this comment.
Here need to check that the current target is RISC-V. As far as I know, we can't get target info in EightByteInfo class. Maybe we can add target info to typemanager then we can access target info by it. But doing this is not a high priority.
Collaborator
|
The error output |
Change-Id: Ic9ada21c3689d2fc9e63d3c425b906f4cfd43f38
Change-Id: I7a7a370ef8f065a90f98bf83044cdc3b8ca4ec4f
Change-Id: Iba5040379c6233672e1670ebdaa7200e794c2db1
Change-Id: Ided89d4e797d443242ec3ca227595f945bb73d28
Change-Id: I3b3391046000b2b908c8dbd657f76e44054d0101
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change-Id: Id4bf54bb8da5cb3b98769809ad316f14101b0ff1