iOS CompletedState includes a read-only data controller; omit set from core
#786
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KVSRoyal
commented
Jan 23, 2026
Comment on lines
+62
to
+65
| public func makeReadOnly() -> ReadOnlyDataController? { | ||
| value.invokeMethod("makeReadOnly", withArguments: []) | ||
| .map { .createInstance(value: $0) } | ||
| } |
Contributor
Author
There was a problem hiding this comment.
Question for reviewers: is this something that we actually want users to be able to access on core/ios/android/etc? It strikes me as a helper function that's been exposed to users.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## player-1-dot-zero #786 +/- ##
====================================================
Coverage ? 85.90%
====================================================
Files ? 507
Lines ? 22897
Branches ? 2656
====================================================
Hits ? 19670
Misses ? 2898
Partials ? 329 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
setfrom coreReadOnlyDataController. This previously just logged an error and did nothing. Omittingsetis a cleaner API. This is outside the scope of the original issue but was discussed with @KetanReddyReadOnlyDataControlleron iOS. This wraps the core version of the same. ACompletedStateon iOS will now include this controller.makeReadOnly()to the iOSDataController. It's not used on iOS, however.Why
#219
We should have parity across all platforms. This updates ios to match the same public API as the core for the Read-Only Data Controller. The read-only version of the data controller was introduced to allow users to access data / evaluate bindings after a flow has ended.
Change Type (required)
Indicate the type of change your pull request is:
patchminormajorN/A(this is part of the major release)Does your PR have any documentation updates?